Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Move AdlsIngestionApp details (app ID and client secret) to "AzureDataLakeStorageV1" section of the config #22

Closed
kivancmuslu opened this issue Dec 11, 2020 · 1 comment
Closed

Move AdlsIngestionApp details (app ID and client secret) to "AzureDataLakeStorageV1" section of the config #22

kivancmuslu opened this issue Dec 11, 2020 · 1 comment
Assignees
@myles-mcleroy
Labels
Collectors Refers to a change specific to collectors P3 Represents priority 3 Ramp-up Friendly Similar to "good first issue"

Comments

@kivancmuslu
Copy link
Member

Currently, this config is provided through environment variables (function app variables) and set through the release definition. However, moving this to main config, especially to the section related to AzureDataLakeStorageV1 keeps things that are relevant together, making it more difficult to forget updates on correlated stuff.
@kivancmuslu kivancmuslu added Collectors Refers to a change specific to collectors P3 Represents priority 3 Ramp-up Friendly Similar to "good first issue" labels Dec 11, 2020
@myles-mcleroy myles-mcleroy self-assigned this Jan 8, 2021
@myles-mcleroy myles-mcleroy mentioned this issue Jan 19, 2021
Closed
@kivancmuslu
Copy link
Member Author

Closed at #42

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@myles-mcleroy myles-mcleroy

Labels
Collectors Refers to a change specific to collectors P3 Represents priority 3 Ramp-up Friendly Similar to "good first issue"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kivancmuslu @myles-mcleroy