Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add daily builds for BuildJIT=false configuration. #42

Merged
merged 1 commit into from Jan 12, 2016
Merged

Add daily builds for BuildJIT=false configuration. #42

merged 1 commit into from Jan 12, 2016

Conversation

dilijev
Copy link
Contributor

@dilijev dilijev commented Jan 9, 2016

Add daily builds for BuildJIT=false configuration.

@msftclas
Copy link

msftclas commented Jan 9, 2016

Hi @dilijev, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Doug Ilijev). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@dilijev
Copy link
Contributor Author

dilijev commented Jan 9, 2016

@dotnet-bot test ci please

@dilijev
Copy link
Contributor Author

dilijev commented Jan 9, 2016

@digitalinfinity It was easier to add these than I expected. If you have a chance, could you make sure this looks alright?

dilijev
dilijev reviewed Jan 9, 2016
View reviewed changes
netci.groovy
def analysisConfig = buildType in ['release']

def buildScript = "call jenkins.buildone.cmd ${buildArch} ${buildType}"
buildScript += ' "/p:BuildJIT=false"' // don't build JIT on this build task
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this flag case-sensitive or did I get it right?

@dilijev
Copy link
Contributor Author

dilijev commented Jan 9, 2016

I added triggers for the two groups of daily build tasks so we can trigger them on demand without triggering all of the dailies.

As always trigger with @dotnet-bot test <pattern> please where the patterns are described in the regex diagrams below:

msbuild12:
http://regexper.com/#(win(dows)%3F%5Cs*7%7C(dev%7Cmsbuild)%5Cs*12)

disablejit:
http://regexper.com/#(disablejit%7Cno(build)%3Fjit%7Cbuildjit%3Dfalse)

@dilijev dilijev assigned curtisman and unassigned digitalinfinity Jan 11, 2016
@dilijev
Copy link
Contributor Author

dilijev commented Jan 11, 2016

@curtisman: @digitalinfinity asked me to add daily tasks to check the build and test configuration when we don't build the JIT. Can you review?

@MikeHolman MikeHolman mentioned this pull request Jan 11, 2016
Closed
@dilijev
Add daily builds for BuildJIT=false configuration.
5b4afff 
Add group regexes to trigger only certain groups of daily builds on demand.

This includes for Windows 7 / Dev 12 builds:
* win7, windows7, win 7, windows 7
* dev12, dev 12, msbuild12, msbuild 12

And this includes for BuildJIT=false builds:
* disablejit, nojit, nobuildjit, buildjit=false
@dilijev
Copy link
Contributor Author

dilijev commented Jan 11, 2016

@dotnet-bot test ci please

@chakrabot chakrabot merged commit 5b4afff into chakra-core:master Jan 12, 2016
@dilijev dilijev deleted the daily-nojit branch January 12, 2016 01:07
nhat-nguyen added a commit to nhat-nguyen/ChakraCore that referenced this pull request Jun 26, 2019
@nhat-nguyen
Implement output tracing for generator bail-in
007a06b 
Since bailing in happens in the jit'd code, we have to generate code to output the trace. If tracing is enabled, we will fill the array of bail-in symbols in the generator instance (`bailInSymbolsTraceArray`) with their ids and values and finally output them with a call to a runtime helper.

`-trace:bailin` together with `-trace:bailout -verbose` can help us easily debug jit'd generators by comparing the values when bailing out for `yield` and bailing in:

```
BailOut: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #003f Opcode: Yield Kind: BailOutForGeneratorYield
BailOut:   Register #  0: Not live
BailOut:   Register #  1: Constant table
BailOut:   Register #  2: Register r15     16, value: 0x0000023CE132EEA0 (Yield Return Value)
BailOut:   Register #  3: Register r12     13, value: 0x0001000000000004
BailOut:   Return Value: 0x0000023CE132EEA0

BailIn: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: chakra-core#42
BailIn: Register #   3, value: 0x0001000000000004
```

```
BailOut: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #006b Opcode: Yield Kind: BailOutForGeneratorYield
BailOut:   Register #  0: Not live
BailOut:   Register #  1: Constant table
BailOut:   Register #  3: Register r15     16, value: 0x0000023CE133E060 (Yield Return Value)
BailOut:   Return Value: 0x0000023CE133E060

BailIn: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #006e
BailIn: No symbols reloaded
```
nhat-nguyen added a commit to nhat-nguyen/ChakraCore that referenced this pull request Jun 26, 2019
@nhat-nguyen
Implement output tracing for generator bail-in
ccd37b7 
Since bailing in happens in the jit'd code, we have to generate code to output the trace. If tracing is enabled, we will fill the array of bail-in symbols in the generator instance (`bailInSymbolsTraceArray`) with their ids and values and finally output them with a call to a runtime helper.

`-trace:bailin` together with `-trace:bailout -verbose` can help us easily debug jit'd generators by comparing the values when bailing out for `yield` and bailing in:

```
BailOut: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #003f Opcode: Yield Kind: BailOutForGeneratorYield
BailOut:   Register #  0: Not live
BailOut:   Register #  1: Constant table
BailOut:   Register #  2: Register r15     16, value: 0x0000023CE132EEA0 (Yield Return Value)
BailOut:   Register #  3: Register r12     13, value: 0x0001000000000004
BailOut:   Return Value: 0x0000023CE132EEA0

BailIn: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: chakra-core#42
BailIn: Register #   3, value: 0x0001000000000004
```

```
BailOut: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #006b Opcode: Yield Kind: BailOutForGeneratorYield
BailOut:   Register #  0: Not live
BailOut:   Register #  1: Constant table
BailOut:   Register #  3: Register r15     16, value: 0x0000023CE133E060 (Yield Return Value)
BailOut:   Return Value: 0x0000023CE133E060

BailIn: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #006e
BailIn: No symbols reloaded
```
nhat-nguyen added a commit to nhat-nguyen/ChakraCore that referenced this pull request Jun 27, 2019
@nhat-nguyen
Implement output tracing for generator bail-in
451bba5 
Since bailing in happens in the jit'd code, we have to generate code to output the trace. If tracing is enabled, we will fill the array of bail-in symbols in the generator instance (`bailInSymbolsTraceArray`) with their ids and values and finally output them with a call to a runtime helper.

`-trace:bailin` together with `-trace:bailout -verbose` can help us easily debug jit'd generators by comparing the values when bailing out for `yield` and bailing in:

```
BailOut: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #003f Opcode: Yield Kind: BailOutForGeneratorYield
BailOut:   Register #  0: Not live
BailOut:   Register #  1: Constant table
BailOut:   Register #  2: Register r15     16, value: 0x0000023CE132EEA0 (Yield Return Value)
BailOut:   Register #  3: Register r12     13, value: 0x0001000000000004
BailOut:   Return Value: 0x0000023CE132EEA0

BailIn: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: chakra-core#42
BailIn: Register #   3, value: 0x0001000000000004
```

```
BailOut: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #006b Opcode: Yield Kind: BailOutForGeneratorYield
BailOut:   Register #  0: Not live
BailOut:   Register #  1: Constant table
BailOut:   Register #  3: Register r15     16, value: 0x0000023CE133E060 (Yield Return Value)
BailOut:   Return Value: 0x0000023CE133E060

BailIn: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #006e
BailIn: No symbols reloaded
```
nhat-nguyen added a commit to nhat-nguyen/ChakraCore that referenced this pull request Jun 27, 2019
@nhat-nguyen
Implement output tracing for generator bail-in
38df3a6 
Since bailing in happens in the jit'd code, we have to generate code to output the trace. If tracing is enabled, we will fill the array of bail-in symbols in the generator instance (`bailInSymbolsTraceArray`) with their ids and values and finally output them with a call to a runtime helper.

`-trace:bailin` together with `-trace:bailout -verbose` can help us easily debug jit'd generators by comparing the values when bailing out for `yield` and bailing in:

```
BailOut: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #003f Opcode: Yield Kind: BailOutForGeneratorYield
BailOut: Register # 0: Not live
BailOut: Register # 1: Constant table
BailOut: Register # 2: Register r15 16, value: 0x0000023CE132EEA0 (Yield Return Value)
BailOut: Register # 3: Register r12 13, value: 0x0001000000000004
BailOut: Return Value: 0x0000023CE132EEA0

BailIn: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: chakra-core#42
BailIn: Register # 3, value: 0x0001000000000004
```

```
BailOut: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #006b Opcode: Yield Kind: BailOutForGeneratorYield
BailOut: Register # 0: Not live
BailOut: Register # 1: Constant table
BailOut: Register # 3: Register r15 16, value: 0x0000023CE133E060 (Yield Return Value)
BailOut: Return Value: 0x0000023CE133E060

BailIn: function: func68 ( (chakra-core#1.1), chakra-core#2) offset: #006e
BailIn: No symbols reloaded
```
chakrabot pushed a commit that referenced this pull request Jul 2, 2019
@nhat-nguyen
[MERGE #6183 @nhat-nguyen] Implement output tracing for generator bai…
773e5f9 
…l-in

Merge pull request #6183 from nhat-nguyen:trace

Since bailing in happens in the jit'd code, we have to generate code to output the trace. If tracing is enabled, we will fill the array of bail-in symbols in the generator instance (`bailInSymbolsTraceArray`) with their ids and values and finally output them with a call to a runtime helper.

`-trace:bailin` together with `-trace:bailout -verbose` can help us easily debug jit'd generators by comparing the values when bailing out for `yield` and bailing in:

```
BailOut: function: func68 ( (#1.1), #2) offset: #003f Opcode: Yield Kind: BailOutForGeneratorYield
BailOut:   Register #  0: Not live
BailOut:   Register #  1: Constant table
BailOut:   Register #  2: Register r15     16, value: 0x0000023CE132EEA0 (Yield Return Value)
BailOut:   Register #  3: Register r12     13, value: 0x0001000000000004
BailOut:   Return Value: 0x0000023CE132EEA0

BailIn: function: func68 ( (#1.1), #2) offset: #42
BailIn: Register #   3, value: 0x0001000000000004
```

```
BailOut: function: func68 ( (#1.1), #2) offset: #006b Opcode: Yield Kind: BailOutForGeneratorYield
BailOut:   Register #  0: Not live
BailOut:   Register #  1: Constant table
BailOut:   Register #  3: Register r15     16, value: 0x0000023CE133E060 (Yield Return Value)
BailOut:   Return Value: 0x0000023CE133E060

BailIn: function: func68 ( (#1.1), #2) offset: #006e
BailIn: No symbols reloaded
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@curtisman curtisman

Labels
Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dilijev @msftclas @digitalinfinity @curtisman @chakrabot