ModuleEvaluation should return undefined #6272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenparsing
reviewed
Sep 9, 2019
bin/ch/WScriptJsrt.cpp
Outdated
| @@ -2022,6 +2022,16 @@ HRESULT WScriptJsrt::ModuleMessage::Call(LPCSTR fileName) | |||
| } | |||
| } | |||
| } | |||
| else | |||
There was a problem hiding this comment.
Did you look into whether it's possible (or makes sense) to add a test case to bin/NativeTests/JsRTApiTest.cpp? I haven't dug around in that file so I'm not sure. If we can and it's not too much work then this probably belongs over there.
Otherwise, I think it would be fine for this PR to just make the change to SourceTextModuleRecord.cpp and we can worry about the test later.
There was a problem hiding this comment.
JsRTApiTest doesn't currently test JsModuleEvaluation so it would mean adding a new test to it - that aside I don't really know how that file works so for now I have updated to not have a test and merely revert the unintentional change.
rhuanjl
force-pushed
the
moduleReturnUndefined
branch
from
3d49041
to
bcde2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up on discussion in #6266 this reverts an unintended side-effect of #6171
The successful completion value of a module is
undefined- this was not tested and the change in #6171 had resulted in it being{done : true}instead.With this change that is reverted additionally a crude test is added - every time a root module is evaluated in ch the completion value is checked to confirm that it is
undefined- this would make every single module test fail if this error was ever re-introduced.I note the discussion in #6266 was sparked by a desire for the return value to be the result of the last statement in the module - like with a script - this change will not do that as:
a) it seems that was not done before
b) that would be very complex and
c) that is not per specification see https://tc39.es/ecma262/#sec-moduleevaluation