Add support for specifying a custom AksNodeResourceGroupName #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giventocode
approved these changes
Mar 13, 2024
BMurri
reviewed
Mar 14, 2024
| @@ -31,6 +31,7 @@ public class Configuration : UserAccessibleConfiguration | |||
|
|
|||
| public abstract class UserAccessibleConfiguration | |||
| { | |||
| public string AksNodeResourceGroupName { get; set; } | |||
There was a problem hiding this comment.
The only thing I would add would be to validate in Deployer.cs that this is not set for Upgrades (to follow the pattern of most other "initial deployment only" properties). There are already other properties where that's done, it should be in the same place.
Will this also be done in the CoA deployer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #760