Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in NativeMethods.txt #65

Closed
CBenghi opened this issue Jan 24, 2021 · 0 comments · Fixed by #66
Closed

Comments in NativeMethods.txt #65

CBenghi opened this issue Jan 24, 2021 · 0 comments · Fixed by #66

Comments

@CBenghi
Copy link
Contributor

CBenghi commented Jan 24, 2021

It would be helpful to add comments to the NativeMethods.txt file to make the list of lines more expressive.

For example, something like:

// GetLastInputInfo is used to determine if the user is idle in module xxx
GetLastInputInfo
// todo: remove SetWindowsHookEx and use class yyy instead
SetWindowsHookEx

Having read the code

foreach (TextLine line in nativeMethodsTxt.Lines)
{
context.CancellationToken.ThrowIfCancellationRequested();
string name = line.ToString();
if (string.IsNullOrWhiteSpace(name))
{
continue;
}

this seems easy... I'll post a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant