Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote inline array structs to namespace to encourage reuse #700

Closed
AArnott opened this issue Sep 30, 2022 · 0 comments · Fixed by #707
Closed

Promote inline array structs to namespace to encourage reuse #700

AArnott opened this issue Sep 30, 2022 · 0 comments · Fixed by #707
Assignees
@AArnott
Labels
enhancement New feature or request

Comments

@AArnott
Copy link
Member

AArnott commented Sep 30, 2022

The inline array structs that we generate are nested in their consuming structs, which prevents reuse across structs that have elements of the same type. For example, inline char arrays are quite common, and needn't be generated for every consumer, provided their lengths are the same.
@AArnott AArnott added the enhancement New feature or request label Sep 30, 2022
@AArnott AArnott self-assigned this Oct 4, 2022
@AArnott AArnott mentioned this issue Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reuse inline array structs across all users microsoft/CsWin32
1 participant
@AArnott