detour_sign_extend is implemented incorrectly

[valco1994]

Currently, detour_sign_extend has the following implementation:

inline INT64 detour_sign_extend(UINT64 value, UINT bits)
{
    const UINT left = 64 - bits;
    const INT64 m1 = -1;
    const INT64 wide = (INT64)(value << left);
    const INT64 sign = (wide < 0) ? (m1 << left) : 0;
    return value | sign;
}

But the sign computation is incorrect here. The result should be the following: left upper bits of sign and then bits lower bits of value. But m1 is shifted left by left bits in the current implementation, so we will use bits bits of the sign. It's an error.

The proper sign computation should be

const INT64 sign = (wide < 0) ? (m1 << bits) : 0;

As an example, you can consider the following case that I met:

• value is 0xffea2e4, bits is 28.
• The expected result is 0xfffffffffffea2e4: 64 - 28 = 36 upper bits of the sign and then 28 bits of the value.
• The actual result of the current implementation is 0xfffffff00ffea2e4 , that is obviously wrong.