Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiscPSSDiagInfo ... ServerProperty. Error may occur collecting data and it isn't clear what we might be missing #149

Closed
gambit9009 opened this issue Mar 17, 2022 · 1 comment
Assignees
Labels
enhancement wave 1 - closed consider this issue for next wave of fixes

Comments

@gambit9009
Copy link
Contributor

gambit9009 commented Mar 17, 2022

miscpssdiaginfo captures info under --ServerProperty--

If you get an error, the table might be broken into 2 tables. (by design)
You may see that table split by something like...

RegQueryValueEx() returned error 2, 'The system cannot find the file specified.'

We could possibly improve the way it is collecting this info or at least have better error handling or reporting. Like what value was this line going after that got this error? What info might we be missing?

There is a comment on line 78 ...

--we need to get this into a different rowset because it may fail

We are trying to read the registry here ...

EXEC xp_instance_regread

There may be other areas to approve, but talked about starting there.

@gambit9009
Copy link
Contributor Author

@hacitandogan We will assign this to you

@gambit9009 gambit9009 added the actively worked Current issues being worked on right now label Apr 13, 2022
@PiJoCoder PiJoCoder removed the actively worked Current issues being worked on right now label Apr 20, 2022
@PiJoCoder PiJoCoder added the wave 1 - closed consider this issue for next wave of fixes label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement wave 1 - closed consider this issue for next wave of fixes
Projects
None yet
Development

No branches or pull requests

3 participants