Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system requires Visual Studio to be installed on C: #2976

Closed
jeffnn opened this issue Jun 16, 2020 · 4 comments
Closed

Build system requires Visual Studio to be installed on C: #2976

jeffnn opened this issue Jun 16, 2020 · 4 comments

Comments

@jeffnn
Copy link
Collaborator

jeffnn commented Jun 16, 2020

(At least) two issues:

In several files, use of the %ProgramFilesx86% and %ProgramFiles% which map to c: even if VS is on d:

Use of [HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\VisualStudio\14.0;InstallDir] in cmake\modules\FindDiaSDK.cmake, which isn't populated by VS2019 install.

@hekota
Copy link
Member

hekota commented Sep 15, 2020

Jeff, if you have VS installed on the d: is there vswhere.exe in c:\Program Files (x86)\Microsoft Visual Studio\Installer? I am not sure how else to detect the VS install location since VS2019 does not populate the registry entry.

@jeffnn
Copy link
Collaborator Author

jeffnn commented Sep 15, 2020

I do have vswhere in that directory on my machine. TBH I can't remember, but i may originally have had VS on c:, then uninstalled it and re-installed it on d: in order to make space on c:
(So it's possible it wouldn't be there on c: if I had only ever installed on d:)

@pow2clk
Copy link
Member

pow2clk commented Sep 25, 2020

@hekota Did your recent changes to hctbuild.cmd resolve this?

@hekota
Copy link
Member

hekota commented Sep 25, 2020

Yes, I believe this should be resolved by #3138.

@hekota hekota closed this as completed Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants