initial commit for aka.ms/econml doc migration #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fverac
force-pushed
the
fverac/migrate_akamseconml
branch
from
83c8d66
to
7055354
Compare
vsyrgkanis
approved these changes
Jul 14, 2022
kbattocchi
approved these changes
Jul 26, 2022
doc/spec/overview.rst
Outdated
| <div class="ms-grid " style = "text-align: left; box-sizing: border-box; display: block; margin-left: auto; margin-right: auto; max-width: 1600px; position: relative; padding-left: 0; padding-right: 0; width: 100%;"> | ||
| <div class="ms-row" style = "text-align: left; box-sizing: border-box; -webkit-box-align: stretch; align-items: stretch; display: flex; flex-wrap: wrap; margin-left: 3px; margin-right: 3px;"> | ||
| <div class="m-col-8-24 x-hidden-focus" style = "text-align: left; box-sizing: border-box; float: left; margin: 0; padding-left: 1vw; padding-right: 1vw; position: relative; width: 33.33333%;"> | ||
| <p style="text-align:center;"><img loading="lazy" class="size-full wp-image-656358 aligncenter x-hidden-focus" src="https://www.microsoft.com/en-us/research/uploads/prod/2020/05/imgFlexible.png" alt="Flexible icon" width="92" height="92"></p><p style="text-align: center"><b>Flexible</b></p><p class="x-hidden-focus">Allows for flexible model forms that do not impose strong assumptions, including models of heterogenous responses to treatment.</p><p> </p></div> |
There was a problem hiding this comment.
It might be better to copy the images locally rather than accessing them from www.microsoft.com.
| @@ -10,7 +10,6 @@ __pycache__/ | |||
| *.log | |||
| *.out | |||
| *.synctex.gz | |||
There was a problem hiding this comment.
This change is fine.
If you need to make any further changes to this PR, you might consider also changing azure-pipelines.yml to exempt .gitignore changes so that you don't have to run the full set of checks, since all of your other changes are in the doc subdirectory.
fverac
commented
Jul 26, 2022
There was a problem hiding this comment.
sphinx-doc/sphinx#10705
Because of issues with sphinx 5.1.0
fverac
commented
Jul 26, 2022
| @@ -71,7 +71,7 @@ jobs: | |||
| - script: 'pip install git+https://github.com/slundberg/shap.git@d1d2700acc0259f211934373826d5ff71ad514de' | |||
| displayName: 'Install specific version of shap' | |||
|
|
|||
| - script: 'pip install sphinx sphinx_rtd_theme' | |||
| - script: 'pip install sphinx!=5.1.0 sphinx_rtd_theme' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is some useful documentation on the Microsoft EconML project page but it can be hard to find. Migrating the information over to the package docs should increase visibility.