add matplotlib version ceiling #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
reviewed
Sep 20, 2022
| @@ -69,7 +69,8 @@ all = | |||
| tensorflow > 1.10, < 2.3 | |||
| ; Version capped due to tensorflow incompatibility | |||
| protobuf < 4 | |||
| matplotlib | |||
| ; Version capped due to shap incompatibility | |||
| matplotlib < 3.6.0 | |||
There was a problem hiding this comment.
Consider using
Suggested change
| matplotlib < 3.6.0 | |
| matplotlib != 3.6.0 |
if this seems like a matplotlib issue that will be fixed soon.
There was a problem hiding this comment.
Doesn't seem like matplotlib plans to address this judging by this issue:
| @@ -69,7 +69,8 @@ all = | |||
| tensorflow > 1.10, < 2.3 | |||
| ; Version capped due to tensorflow incompatibility | |||
| protobuf < 4 | |||
| matplotlib | |||
| ; Version capped due to shap incompatibility | |||
| matplotlib < 3.6.0 | |||
There was a problem hiding this comment.
Note that whatever change you make here, the same change should also be made to the plt extra.
AnthonyCampbell208
pushed a commit
to AnthonyCampbell208/EconML-CS696DS
that referenced
this pull request
Apr 20, 2023
* add matplotlib version ceiling * complete matplotlib cap Signed-off-by: AnthonyCampbell208 <78286293+AnthonyCampbell208@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that a recently released matplotlib version has broken some things for the shap library, which in turn causes some of our tests/functionality to fail.
Capping the version to avoid for now.
Relevant issues:
shap/shap#2687
SeldonIO/alibi#774