CMakeLists: fix dependency on Microsoft-ETW-ESE.man #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMakeLists.txt configuration in `src\_etw` specifies the non-existing DEPENDS input when calling the message compiler for Microsoft-ETW-ESE.man. This causes the following error during rebuild — most likely due to an incorrect build order: Generating ../../../../gen/_etw/Microsoft-ETW-ESE.h, ../../../../gen/_etw/Microsoft-ETW-ESE.rc mc : error : 0x2 trying to open file <[...]/build/gen/_etw/Microsoft-ETW-ESE.man>. Fix this by making the command depend on `Microsoft-ETW-ESE.man`.
|
Thanks, I had the same issue. |
|
Thanks, I merged this internally, as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMakeLists.txt configuration in
src\_etwspecifies the non-existingdependency when calling the message compiler for
Microsoft-ETW-ESE.man.This causes the following error during rebuild in my environment, most likely
due to an incorrect build order:
This PR fixes it by making the command depend on
Microsoft-ETW-ESE.man.