New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the baselines results csvs and data #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to delete the csvs in preprocessing/targets
(and not move them). Is that intended?
fs_mol/plotting/utils.py
Outdated
# colors = [200, 128, 64, 160, 10, 32] | ||
# color_set = [plt.get_cmap("plasma").colors[x] for x in colors] | ||
# colors = [175, 170, 160, 64, 32, 10] | ||
# color_set = [plt.get_cmap("nipy_spectral")(x) for x in colors]# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop all this?
fs_mol/plotting/utils.py
Outdated
for i, model_name in enumerate(model_summaries.keys()): | ||
color = plt.get_cmap("plasma").colors[i * 50 + 50] | ||
for j, model_name in enumerate(model_summaries.keys()): | ||
# color = plt.get_cmap("plasma").colors[j * 50 + 40] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this line too?
Yes, they are put in datasets/targets in another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe also edit the PR title to include the fact that this also adds the data 🙂
Adding baselines summary csvs that are used by notebooks/visualize to plot everything. Update this PR 'ed branch with final PN results when available.
Also small changes to plotting utils to allow consistent task highlighting/less naff colours etc.
also moved the target_info csvs