Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean metric function #32

Merged
merged 7 commits into from Sep 2, 2021
Merged

Mean metric function #32

merged 7 commits into from Sep 2, 2021

Conversation

megstanley
Copy link
Contributor

@megstanley megstanley commented Sep 1, 2021

Fixing the aggregation/taking mean over metrics so that within task means are taken before means over multiple tasks are taken.

I think I got all the instances where this occurs. Let me know if I missed one.

This is on top of the multiway validation PR for now.

fs_mol/utils/protonet_utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mmjb mmjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though I would prefer to keep more of the existing logging if possible.

@megstanley megstanley merged commit a4d882e into main Sep 2, 2021
@megstanley megstanley deleted the feat/mean-metric-func branch September 3, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants