Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other di containers #126

Closed
da1rren opened this issue May 26, 2021 · 5 comments
Closed

Other di containers #126

da1rren opened this issue May 26, 2021 · 5 comments
Assignees

Comments

@da1rren
Copy link

da1rren commented May 26, 2021

Hey Guys,

We're attempting to use this in a .net framework application that uses autofac. While attempting to register the various dependencies:

  • ConfigurationFeatureDefinitionProvider
  • FeatureManager
  • EmptySessionManager
  • FeatureManagerSnapshot

I've discovered that they are all sealed, is there any guidance or is it even possible to use this without resorting to reflection hacks?

@jeffcollaboro
Copy link

... or any other number of containers, Simple Injector etc, These classes are the public interface into feature flags they shouldn't be internal, we need to instantiate them to use this.

@danielmackay
Copy link

We're having this problem also. It would be great to see some guidance of how to use the FeatureManager with other IoC containers.

@zhiyuanliang-ms
Copy link
Contributor

Update:
The PR #302 of exposing FeatureManager to public has been merged into main branch. Now the FeatureManagement should be compatible with other DI framework.

@zhiyuanliang-ms
Copy link
Contributor

Fixed in release 3.1.0

@zhiyuanliang-ms
Copy link
Contributor

I created a repo to demonstrate how to use Microsoft.FeatureManagement in third-party Di containers: https://github.com/zhiyuanliang-ms/FeatureManagement-Dotnet-DependencyInjection
:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants