Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making IFeatureSettingsProvider public #46

Closed
pardahlman opened this issue Jan 31, 2020 · 3 comments
Closed

Consider making IFeatureSettingsProvider public #46

pardahlman opened this issue Jan 31, 2020 · 3 comments

Comments

@pardahlman
Copy link

There are many system in the wild that uses other feature toggling frameworks that does not load its data from IConfiguration, nor has a data source that can be used as a ConfigurationProvider. The idea behind making IFeatureSettingsProvider public is that these systems could use a custom implementation as part of their migration story over to this toggle framework.

@slomangino123
Copy link

Looking into a way to feature flag api endpoints easily I stumbled across the same issue as @pardahlman. As such we are looking for a way to toggle feature flags without using IConfiguration but rather a third party service. Being able to provide a decorated IFeatureSettingsProvider would allow sourcing feature flags from anywhere.

@josephwoodward
Copy link
Contributor

josephwoodward commented Apr 17, 2020

Came here to say the same thing. It'd be great to be able to use this library for more than IConfiguration based datasources (such as other feature toggling services like LaunchDarkly). Making this interface public would enable that.

@jimmyca15
Copy link
Member

This has been added in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants