Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many public APIs currently typed to any should be constrained to Serializable #1239

Closed
DLehenbauer opened this issue Feb 12, 2020 · 1 comment
Closed

Many public APIs currently typed to any should be constrained to Serializable #1239

DLehenbauer opened this issue Feb 12, 2020 · 1 comment
Labels
api area: dev experience Improving the experience of devs building on top of fluid area: runtime Runtime related issues

Comments

@DLehenbauer
Copy link
Contributor

Many of our public APIs predate Serializable, and instead are incorrectly typed as any, 'IMapLike, PropertySet`, etc. (which are all overly permissive.) Usually, this manifests as data loss when the values are transmitted to remote clients or reloaded from a snapshot.

Constraining these types to <T extends Serializable = Serializable> would help guard against accidental loss at compile time. (See runtime/matrix/src/matrix.ts as an example).
@DLehenbauer DLehenbauer added good first issue Good for newcomers area: runtime Runtime related issues labels Feb 12, 2020
@DLehenbauer DLehenbauer mentioned this issue Feb 12, 2020
Merged
@tylerbutler tylerbutler added this to the Build 2020 milestone Feb 18, 2020
@curtisman curtisman added the api label May 8, 2020
@ghost ghost added the triage label May 8, 2020
@curtisman curtisman modified the milestones: Build 2020, Next 2020 May 8, 2020
@curtisman curtisman added the area: dev experience Improving the experience of devs building on top of fluid label May 8, 2020
@curtisman curtisman removed the triage label May 30, 2020
@danielroney danielroney removed the good first issue Good for newcomers label Aug 28, 2020
@vladsud
Copy link
Contributor

vladsud commented May 28, 2021

I believe this is essentially a dup of #136 and we made a decision to punt it.
Please reactivate if you disagree

@vladsud vladsud closed this as completed May 28, 2021
@danielroney danielroney removed this from the Next milestone Jun 2, 2021
@ChumpChief ChumpChief mentioned this issue Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api area: dev experience Improving the experience of devs building on top of fluid area: runtime Runtime related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tylerbutler @DLehenbauer @curtisman @vladsud @danielroney