Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objects Stored on DDS's should be frozen #1792

Closed
skylerjokiel opened this issue Apr 15, 2020 · 2 comments
Closed

Objects Stored on DDS's should be frozen #1792

skylerjokiel opened this issue Apr 15, 2020 · 2 comments
Labels
api area: dds Issues related to distributed data structures design-required This issue requires design thought

Comments

@skylerjokiel
Copy link
Contributor

We should freeze objects once they are stored on a DDS to prevent bugs with data manipulation not reflected in the data structures.

See:
#136
@skylerjokiel skylerjokiel added the area: dds Issues related to distributed data structures label Apr 15, 2020
@skylerjokiel skylerjokiel added this to the Future milestone Apr 15, 2020
@curtisman curtisman modified the milestones: Future, Next 2020 Apr 15, 2020
@anthony-murphy
Copy link
Contributor

i have some performance concerns with this, so we should be careful to profile here. we may want to make this configurable, so it can be turned off in prod, and only take the perf hit in test and dev

@curtisman curtisman added api design-required This issue requires design thought labels Oct 26, 2020
@vladsud
Copy link
Contributor

vladsud commented May 28, 2021

Issue #5738 looks into a bunch of options in the space and I believe arrives to conclusion that we need to implement deep cloning (semantically at least), not freezing / making things readonly.
I'd propose we use #5738 to continue this discussion and close this one as a dup of it.
Please reactivate if disagree.

@vladsud vladsud closed this as completed May 28, 2021
@vladsud vladsud mentioned this issue May 28, 2021
Closed
4 tasks
@danielroney danielroney removed this from the Next milestone Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api area: dds Issues related to distributed data structures design-required This issue requires design thought
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@anthony-murphy @skylerjokiel @curtisman @vladsud @danielroney