Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to exclude unreferenced components from the getLatest snapshot #235

Closed
KRyan opened this issue Oct 2, 2019 · 2 comments
Closed
Assignees
Labels
area: runtime Runtime related issues perf

Comments

@KRyan
Copy link
Member

KRyan commented Oct 2, 2019

Scenario 1: A user adds 100 atmentions, then deletes them all. The 100 atmentions are still in the document, breaking single-blob file read and compromising boot perf.
Implication: We need a way to mark a component to indicate that it should not be included in the getLatest snapshot.

Scenario 2: The user views a Fluid Component in OWA, but that component was removed. However, the user can still use some UI to see the component in the state it was created.
Implication: We cannot truly delete a component.

Short term, we could use a convention to prevent SP from deleting a component.

Longer term, we should design an app load template experience.

@vladsud @cosmincatrinescu @ZeguangWu @aboktor

@vladsud vladsud self-assigned this Oct 3, 2019
@curtisman curtisman added the perf label Jan 21, 2020
@vladsud
Copy link
Contributor

vladsud commented Jan 31, 2020

#1096 "Design: Creation Flow / Singletons" should address this and not require new work

@curtisman curtisman added the area: runtime Runtime related issues label Jan 31, 2020
@curtisman curtisman added this to the Future milestone Feb 2, 2020
@curtisman curtisman modified the milestones: Future, Next 2020 Feb 11, 2020
@vladsud vladsud modified the milestones: Next 2020, July 2020 Jun 9, 2020
@vladsud vladsud modified the milestones: July 2020, August 2020 Jul 7, 2020
@vladsud vladsud modified the milestones: August 2020, September 2020 Jul 30, 2020
@vladsud vladsud modified the milestones: September 2020, October 2020 Aug 31, 2020
@SamBroner
Copy link
Contributor

Addressed by other issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues perf
Projects
None yet
Development

No branches or pull requests

5 participants