You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One is toInstrumentedOdspTokenFetcher in odspUtils.ts (used by document service factory), and the other is toInstrumentedTokenFetcher in odspDriverUrlResolverForShareLink.ts (used by url resolver).
I don't think we would need two implementations. And it tripped me up, because I was expecting the behavior of one when looking at the logs, but it was going through the other which doesn't behave the same way.
The text was updated successfully, but these errors were encountered:
In particular, the url resolver one doesn't wrap thrown errors with fetchTokenError errorType, so it is basically impossible to aggregate them together in telemetry, which is a big miss.
One is
toInstrumentedOdspTokenFetcher
inodspUtils.ts
(used by document service factory), and the other istoInstrumentedTokenFetcher
inodspDriverUrlResolverForShareLink.ts
(used by url resolver).I don't think we would need two implementations. And it tripped me up, because I was expecting the behavior of one when looking at the logs, but it was going through the other which doesn't behave the same way.
The text was updated successfully, but these errors were encountered: