Credentials take a long time

[mastercoms]

Starting with v1.17.0, I have noticed that credentials take a very long time:

trace.c:420             performance: 45.110926700 s: git command: 'C:\Program Files\Git\mingw64\bin\git.exe' lfs locks

with v1.16.2:

trace.c:420             performance: 1.501380900 s: git command: 'C:\Program Files\Git\mingw64\bin\git.exe' lfs locks

With the things taking the longest time being:

trace git-lfs: creds: git credential fill ("https", "REDACTED", "")

trace git-lfs: creds: git credential approve ("https", "REDACTED", "")

[jeschu1]

@mastercoms this is interesting, can you try running both with GCM_TRACE=1 on and see if there an obvious spot where the delay is coming from?

[mastercoms]

GCM_TRACE=1 did not produce any additional output. I also tried git config --global credential.writelog true but .git/credential.log is empty.

[jeschu1]

@mastercoms setting the env variable to GCM_TRACE=1 should be giving us additional output. Strange that didn't work. Can you please try again? Before running please do a dump of the env variables and double check GCM_TRACE=1 is there.

[mastercoms]

PS C:\[git repo path]> $env:GCM_TRACE
1

PS C:\[git repo path]> git lfs locks
<just lists locked files with no additional output>

Am I doing something wrong?

Also, I tested v1.18.2 and credentials are as fast as v1.16.2. Thank you.

[jeschu1]

@mastercoms can you try cloning a small repository with GCM_TRACE=1 on, and see if you get extra GCM logging? Thank you!

[mastercoms]

Yes, I do get GCM logging with git clone.