Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviews for NLP Module #25

Closed
Rishit-dagli opened this issue May 31, 2021 · 1 comment
Closed

Reviews for NLP Module #25

Rishit-dagli opened this issue May 31, 2021 · 1 comment

Comments

@Rishit-dagli
Copy link
Contributor

Rishit-dagli commented May 31, 2021

Hi @jlooper,

I really love the way in which these learning materials and curriculum are designed. However, I had some reviews which might help make this better. I don't have any reviews for Sections 1 and 3 and feel they are really great in the current form. Do let me know if I should make a PR addressing any of these reviews.

1-Introduction-to-NLP

This section looks pretty good to me and I don't have any reviews which might help make this better.

2-Tasks

  • For this sentence

🎓 Tokenization Probably the first thing most NLP algorithms have to do is split the text into tokens, or words. While this sounds simple, having to account for punctuation and different language's word and sentence delimiters can make it tricky.

maybe we could give some intuition on why tokenization might be to not only split a sentence when there is whitespace by adding:

Thought it might seem very straightforward to simply split your sentence into words, you might have to use some other methods or add on top of this too.

  • For the Tasks common to NLP section I feel we should add a mention about "word embeddings" owing to its importance. Maybe we could add something like this:

🎓 Embeddings Embeddings are a way to meaningfully convert your text data numerically. This is done in a way so that words with a similar meaning or words used together cluster together in a high dimensional space.

Optionally we could also add:

Try playing around with word embeddings from a quite popular model (Word2Vec) here. Can you see how clicking on one word shows the words with similar meaning clustering around! Eg. if you inspect the word 'toy' you see it clusters with words: 'disney', 'lego', 'playstation', 'console' etc.

However, I do understand this might make it a bit more deep at this stage, what do you think?

3-Translation-Sentiment

This section looks pretty good to me and I don't have any reviews which might help make this better.

This was referenced Jun 1, 2021
@jlooper
Copy link
Contributor

jlooper commented Jun 3, 2021

looking good! thanks!

@jlooper jlooper closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants