Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-M365DSCDeltaReport error showing multiple AADRoleSetting - Displayname = #4019

Closed
RotemDror opened this issue Dec 11, 2023 · 6 comments · Fixed by #4325 or #4330
Closed

New-M365DSCDeltaReport error showing multiple AADRoleSetting - Displayname = #4019

RotemDror opened this issue Dec 11, 2023 · 6 comments · Fixed by #4325 or #4330

Comments

@RotemDror
Copy link

RotemDror commented Dec 11, 2023

Description of the issue

When running New-M365DSCDeltaRepor , even between identical exports, the report contains multiple "AADRoleSetting - Displayname ="

Claiming they are missing

Major Minor Build Revision


1 23 1206 1

Microsoft 365 DSC Version

V1.23.1206.1

Which workloads are affected

Azure Active Directory

The DSC configuration

No response

Verbose logs showing the problem

No response

Environment Information + PowerShell Version

OsName               : Microsoft Windows 11 Enterprise
OsOperatingSystemSKU : EnterpriseEdition
OsArchitecture       : 64-bit
WindowsVersion       : 2009
WindowsBuildLabEx    : 22621.1.amd64fre.ni_release.220506-1250
OsLanguage           : en-US
OsMuiLanguages       : {en-US}


Name                           Value
----                           -----
PSVersion                      5.1.22621.2428
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.2428
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
@andikrueger
Copy link
Collaborator

Could you share a bit of the configurations used and how you ranNew-M365DSCDeltaReport? Thanks!

@FabienTschanz
Copy link
Contributor

I'm unable to reproduce the issue with the latest version 1.24.117.1 with the following configuration:

Node localhost
    {
        AADRoleSetting "Test_1" {
            Displayname = "ABC"
            ActivationMaxDuration = 10
            ActivationReqJustification = $true
            ActivationReqMFA = $true
        }
    }

@ShawnBeckers
Copy link

Could you share a bit of the configurations used and how you ranNew-M365DSCDeltaReport? Thanks!

I'm seeing this issue as well with v1.24.207.2. Below are commands used to generate export and generate delta report.

$Resources = @("AADAdministrativeUnit","AADApplication","AADAuthorizationPolicy","AADGroupLifecyclePolicy","AADGroupsNamingPolicy","AADGroupsSettings","AADNamedLocationPolicy","AADRoleDefinition","AADRoleSetting","AADSecurityDefaults","AADServicePrincipal","AADTenantDetails","AADTokenLifetimePolicy")

Export-M365DSCConfiguration -TenantID $TenantID -ApplicationID $ApplicationID -CertificateThumbprint $CertThumbprint -Components $Resources -Path $Path -FileName $ExportFile

New-M365DSCDeltaReport -Source "$Path$PreviousExportFile" -Destination "$Path$ExportFile" -OutputPath "$Path$ReportFile"

@FabienTschanz
Copy link
Contributor

@ShawnBeckers can you provide us with a source and destination file that leads to the delta? Some sample data should be enough, because we don't know which configuration you set. Thanks!

@ShawnBeckers
Copy link

Here's some sample data I used to reproduce the issue. Would be the same for both source and destination.
sample.txt

@FabienTschanz
Copy link
Contributor

FabienTschanz commented Feb 14, 2024

@ShawnBeckers I think I found the underlying issue. In the configuration you provided to us, can you replace DisplayName with Displayname (lowercase "n") and retry the comparison?

@andikrueger It seems like AADRoleSettings defines the DisplayName property differently in the MOF and the PowerShell export. I'll prepare a pull request to solve that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants