Skip to content

Commit

Permalink
Merged PR 725: Restrict Bounds Control's grab target component to one…
Browse files Browse the repository at this point in the history
…-handed

Bounds Control was relying on hiding other affordances when starting an
interaction to avoid multiple pointers interacting at the same time.
There was an inconsistency, since `GrabbedAffordances` would only have 1
element when starting both grabs at the same time, while
`BoundsControlGrabbable->GetGrabPointers()` would have 2. Keeping both
components consistent (in that only one handed interaction is allowed
for now) gets rid of this and potentially other issues.
  • Loading branch information
julianjimenez-ms committed Apr 6, 2021
1 parent 3c81415 commit b46c044
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Docs/ReleaseNotes.md
Expand Up @@ -23,6 +23,7 @@ keywords: Unreal, Unreal Engine, UE4, HoloLens, HoloLens 2, Mixed Reality, devel
- [UxtMinMaxScaleConstraint is now implicit](#uxtminmaxscaleconstraint-is-now-implicit)
- [Added UxtManipulatorComponent](#added-uxtmanipulatorcomponent)
- [Added new Bounds Control presets without constrained affordances](#added-new-bounds-control-presets-without-constrained-affordances)
- [BoundsControl configured for one-handed interaction](#boundscontrol-configured-for-one-handed-interaction)
- [Breaking changes](#breaking-changes)
- [UxtHandTrackingFunctionLibrary removed](#uxthandtrackingfunctionlibrary-removed)
- [UxtMathUtilsFunctionLibrary's API update](#uxtmathutilsfunctionlibrarys-api-update)
Expand Down Expand Up @@ -124,6 +125,10 @@ This is the new base class for manipulators. It contains common [constraints' lo

The newly added `BoundsControlConstrained.uasset` and `BoundsControlConstrainedWithFaces.uasset` do not include the affordances that are constrained by default in the `BoundsControlExample.umap`, preventing confusion about why they don't rotate.

### BoundsControl configured for one-handed interaction

By default, `UxtGrabTargetComponent` is configured to allow two-handed interaction. Bounds Control only allows interacting with one hand at a time, so it now properly configures its internal `UxtGrabTargetComponent`, getting rid of some undesired situations.

## Breaking changes

### `UxtHandTrackingFunctionLibrary` removed
Expand Down
Expand Up @@ -285,6 +285,7 @@ void UUxtBoundsControlComponent::CreateAffordances()
BoundsControlActor->SetRootComponent(RootComponent);

BoundsControlGrabbable = NewObject<UUxtGrabTargetComponent>(BoundsControlActor);
BoundsControlGrabbable->GrabModes = static_cast<int32>(EUxtGrabMode::OneHanded);
BoundsControlGrabbable->RegisterComponent();
BoundsControlActor->AddInstanceComponent(BoundsControlGrabbable);

Expand Down

0 comments on commit b46c044

Please sign in to comment.