Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Solver pattern to match profile configuration pattern #2798

Closed
SimonDarksideJ opened this issue Sep 17, 2018 · 2 comments
Closed

Refactor Solver pattern to match profile configuration pattern #2798

SimonDarksideJ opened this issue Sep 17, 2018 · 2 comments

Comments

@SimonDarksideJ
Copy link
Contributor

SimonDarksideJ commented Sep 17, 2018

Overview

In reviewing the migration of the Solver framework, it has highlighted some points which don't fit in to the vNext updated patterns. namely the reduction of MonoBehaviours and the user of scriptable config to profile the configuration of components.

As I understand it (and please correct me if I'm wrong), All solvers require and depend on the Solver Handler. The Solver Handler is then primarily responsible for ensuring all the solvers attached to the object are run and maintained.

Thus, Only the SolverHandler actually needs to be a MonoBehaviour, all other solvers should simply be c# scripts using Scriptable Config profiles to attach them to the solver handler (the solver handler should also be able to have N+ number of solvers in it's configuration.

Requirements

  • Solver handler to be refactored to maintain a config profile
  • Solver handler needs to be able to have n+ solvers attached / configured to it
  • Solvers need to be refactored, so that they can can be "attached" through configuration to a Solver handler
  • Solvers independent configuration either needs generalizing (so it can be managed in the handler) or orchestrated to ensure conformity across solvers
  • Ideally, the Solver handler should have a "profile" to enable attaching the same profile to multiple handlers and reduce the configuration overhead (similar to other config profiles)
@Yoyozilla Yoyozilla added Feature Request Feature request from the community and removed Task Feature Request Feature request from the community labels Apr 16, 2019
@polar-kev polar-kev reopened this Mar 12, 2021
@polar-kev polar-kev added this to the MRTK 3.0.0 milestone Mar 12, 2021
@polar-kev polar-kev added this to Needs Triage in [Retired] MRTK Backlog via automation Mar 12, 2021
@david-c-kline david-c-kline changed the title vNext Task: Refactor Solver pattern to match vNext configuration pattern Refactor Solver pattern to match profile configuration pattern Apr 7, 2021
@MaxWang-MS MaxWang-MS self-assigned this May 5, 2021
@david-c-kline david-c-kline moved this from Needs Triage to To do in [Retired] MRTK Backlog Jun 17, 2021
@david-c-kline
Copy link

  • Prefab creation loses the connection to the scriptable object
  • Changes to scriptable object settings at runtime get applied to the asset without cloning
  • How few customer requests around this issue.
  • Is DOTS something we should move closer to?
  • What is the Unity guidance for use of scriptable objects?

@Zee2
Copy link
Contributor

Zee2 commented Oct 5, 2022

Closing as duplicate of #10759 for upcoming Solvers+Constraints unification and refactor. See @RogPodge for more info

@Zee2 Zee2 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2022
[Retired] MRTK Backlog automation moved this from To do to Fixed - Needs Release Notes Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
[Retired] MRTK Backlog
Fixed - Needs Release Notes
Development

No branches or pull requests

8 participants