Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ HoloToolkit no longer supports Unity 5.4.0f1-HTP #497

Closed
riverar opened this issue Feb 2, 2017 · 6 comments
Closed

⚠️ HoloToolkit no longer supports Unity 5.4.0f1-HTP #497

riverar opened this issue Feb 2, 2017 · 6 comments

Comments

@riverar
Copy link

riverar commented Feb 2, 2017

I maintain https://holotoolkit.download and was running builds on Unity 5.4.0f1-HTP. Just a heads up that a recent change (261802b#diff-d7c8f5f8602786a2bff59bc9835eccf9R219) broke compatibility. It's not clear if this project is attempting to maintain Unity back compat. so no patch submitted at this time.

I plan on upgrading Unity on the server.

-----CompilerOutput:-stderr----------
Assets/HoloToolkit/Sharing/Scripts/Spawning/PrefabSpawnManager.cs(219,24):
error CS0266: Cannot implicitly convert type `UnityEngine.Object' to `UnityEngine.GameObject'.
An explicit conversion exists (are you missing a cast?)
-----EndCompilerOutput---------------
@S-Hodgson-MMOARgames
Copy link

S-Hodgson-MMOARgames commented Feb 2, 2017

I don't think it would be too difficult to revert that line, it was a trivial change.

Sorry about that @riverar. I'll have the fix in tomorrow.

@thebanjomatic
Copy link

thebanjomatic commented Feb 2, 2017

I could be wrong, but I don't think there is any expectation that anything beyond the 1.5.4.0 release tag is compatible with Unity 5.4, with the current master branch targeting Unity 5.5 exclusively.

@riverar
Copy link
Author

riverar commented Feb 2, 2017

I upgraded my build box so you don't need to reinsert the cast. We might want to instead note in the Readme that Unity [v.current] is required. Seems more than fair for bleeding edge project.

@StephenHodgson
Copy link
Contributor

StephenHodgson commented Feb 2, 2017

No worries then.

The Editor version is noted in the readme. line 5.

There's been so many improvements and fixes specific for the HoloLens platform recently, it would probably be best to keep current.

@riverar
Copy link
Author

riverar commented Feb 2, 2017

Current Unity Editor Project Version isn't quite the same as Required Unity Editor Version. Suggest revisiting this. @NeerajW @HodgsonSDAS

@StephenHodgson
Copy link
Contributor

StephenHodgson commented Feb 2, 2017

It's now part of #496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants