Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An idea to add functions to MRTK Examples / MaterialGallery for easy understanding by developers. #6724

Closed
HoloMoto opened this issue Nov 24, 2019 · 5 comments
Labels

Comments

@HoloMoto
Copy link

Describe the problem

MRTK sample material gallery scene can understand MRTK StandardShader, but I feel there are some problems.
・Cannot intuitively understand the functions of MRTK StandardShader with HoloLens

If this problem is solved and MRTK StandardShader can be confirmed not only on the Unity editor but also on the actual HoloLens machine, it will lead to understanding of MRTK StandardShader.

Describe the solution you'd like

It would be great if there was a function in the Material Gallery scene of the MRTK example to better understand the functions of the MRTK StandardShader.

Describe alternatives you've considered

I put Slider in the scene as a way to solve the problem
Suggests an idea of ​​changing MRTK StandardShader parameters from a script.

@HoloMoto HoloMoto added the Feature Request Feature request from the community label Nov 24, 2019
@cre8ivepark
Copy link
Contributor

cre8ivepark commented Nov 24, 2019

@Sthesia Thank you HoloMoto! Please let me know if you need any help with opening PR.

@Troy-Ferrell
Copy link
Contributor

@Cameron-Micka as FYI

@Cameron-Micka
Copy link
Member

I love this idea, I agree it will make the scene more interactable while improve understanding. I just returned from paternity leave but hope to take a look at the pull request soon.

@HoloMoto
Copy link
Author

@Cameron-Micka Thank you, I believe the greatness of MRTK StandardShader can be shared with all developers.
I was sick for a while, so I couldn't move.sorry
It's my first time, so I'd be glad if you could tell me what to do.

@polar-kev
Copy link
Contributor

Hey @HoloMoto, there hasn't been any activity on the PR associated with this, #6744. I'm going to close this issue. If you still want to finish the PR, feel free to open it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants