MeshSmoother not destroying original mesh

[edgar-rodrigo-santos]

Describe the problem

I am currently using the MeshSmoother together with the Outline shading using the MRTK2 shader. In our scenario, this needs to be done and undone programatically and leaving the original mesh untoched. It just so happens that when the MeshSmoother component is destroyed, its OnDestroy method wipes out the object mesh and I can't show the original object anymore.

Describe the solution you'd like

MeshSmoother.OnDestroy not having the desctructive behavior.

Describe alternatives you've considered

I have implemented a solution and I'll contribute it if you need to.
In broad strockes, when doing the "MeshReference" to count references to the mesh, I also keep the original "shared mesh" reference inside it. In the OnDestroy() method, in the case there's no more references to it (which is our case), on top of destroying the current mesh, I re-instantiate the original one: meshFilter.mesh = Instantiate(meshReference.InitialMesh);

Additional context

I realize that the smoothed normals are written to the UV2 channel and I might as well just keep them until the object is actually destroyed but I don't think the fix I suggested as any downsides and has the upside of being able to safely remove a MeshSmoother component without issues.

[mihaits]

I am also having this issue with runtime outline enabling/disabling. Another problem is that you can't use MeshOutlineHierarchy if you want to disable outlines since it can only be destroyed. It doesn't implement OnEnable/OnDisable.
My workaround is to disable MeshOutline components instead of destroying them.

[IssueSyncBot]

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!