Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Reader Unit tests #109

Closed
PerthCharern opened this issue Dec 6, 2017 · 3 comments
Closed

Fix Reader Unit tests #109

PerthCharern opened this issue Dec 6, 2017 · 3 comments
Assignees
@PerthCharern

Comments

@PerthCharern
Copy link
Contributor

No description provided.

@xuzhg
Copy link
Contributor

xuzhg commented Dec 7, 2017

@PerthCharern Would you please leave a little bit details here ?

@PerthCharern
Copy link
Contributor Author

@xuzhg I'll take this instead since I need to write some tests for the other two tasks #32 and #50 and I'm sort of halfway done. I'll add you to the review.

Could you pick up some other tasks instead?

@PerthCharern PerthCharern self-assigned this Dec 8, 2017
@xuzhg
Copy link
Contributor

xuzhg commented Dec 8, 2017

Sure！

This was referenced Dec 9, 2017
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PerthCharern PerthCharern

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuzhg @PerthCharern