Object reference for suppression group will rule not defined

[BernieWhite]

Description of the issue

When a suppression group is defined without a rule property an exception occurs.

To Reproduce

Steps to reproduce the issue:

---
apiVersion: github.com/microsoft/PSRule/v1
kind: SuppressionGroup
metadata:
  name: Local.IgnoreKeyVaultTests
spec:
  if:
    name: '.'
    in:
    - 'kv-test-001'

Expected behaviour

I think in this case we should apply the suppression group to all rules. Related to #931

Error output

OperationStopped: Object reference not set to an instance of an object.

Module in use and version:

• Module: PSRule
• Version: v2.0.0-B2201117

Captured output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      7.2.1
PSEdition                      Core
GitCommitId                    7.2.1
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

[ArmaanMcleod]

@BernieWhite I can probably look at this. I should have probably thought about these edge cases when I added this functionality 😄.

To me it would makes sense to apply the suppression group to all rules for both these cases. Although could it get noisy to have warnings for every rule?

[BernieWhite]

To me it would makes sense to apply the suppression group to all rules for both these cases. Although could it get noisy to have warnings for every rule?

I agree.

@ArmaanMcleod We may need to rework the warnings with more testing. But the summary warnings aren't too bad from my testing.

It will only suppress if the object also matches the if condition.

   WARN  3 rule/s were suppressed by suppression group '.\Local.IgnoreACRTests' for 'cr-test-basic'.
   WARN  3 rule/s were suppressed by suppression group '.\Local.IgnoreACRTests' for 'cr-test-premium'.
   WARN  1 rule/s were suppressed by suppression group '.\Local.IgnoreKeyVaultTests' for 'kv-test-001'.