Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server side changes to improve .msapp format. #21

Closed
1 of 3 tasks
MikeStall opened this issue Nov 3, 2020 · 4 comments
Closed
1 of 3 tasks

Server side changes to improve .msapp format. #21

MikeStall opened this issue Nov 3, 2020 · 4 comments

Comments

@MikeStall
Copy link
Contributor

MikeStall commented Nov 3, 2020

Improve the real .msapp format to make conversions easier.

As general principles:

  • avoid double json encoding because that breaks checksums.
  • separate out volatile information (timestamps, per-environment) from stable information.
  • remove fields that are redundant or don't need to be emitted.

Some specific things:

@lesaltzm
Copy link
Collaborator

lesaltzm commented Dec 8, 2020

  • References/Templates.json - CustomProperties are overly complex and cannot be recreated without the server

@lesaltzm
Copy link
Collaborator

lesaltzm commented Dec 11, 2020

  • General noise in properties.json

  • Component Instances have an Index the same as their parents (the only non-top-level control with an index != 0)

  • PublishInfo.Background color gets set by RP after save to lowercase RGBA?

  • Some service connectors serialize both Wadl and Swagger, discussed with Reza, we likely only need one, probably swagger

  • Control UniqueIds are noisy, and are recreated by the server on load anyway, consider skipping them

  • ViewInfo objects have invariant names that are prefixed with an environment-specific guid, can move that to be a DataSetName property

  • Group Container .oam is not included in the .msapp (either wait for package feeds, or add the control template)

@MikeStall
Copy link
Contributor Author

#161 - remove timestamp in sarif files.

@lesaltzm lesaltzm mentioned this issue Mar 9, 2021
@lesaltzm
Copy link
Collaborator

Sample Resources and Sample Data should not be written to the .msapp. The studio should be able to recreate them on load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants