Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerlauncher preventing powershell 7 uninstall/update #10231

Closed
LuanVSO opened this issue Mar 14, 2021 · 20 comments
Closed

powerlauncher preventing powershell 7 uninstall/update #10231

LuanVSO opened this issue Mar 14, 2021 · 20 comments
Assignees
Labels
Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.

Comments

@LuanVSO
Copy link

LuanVSO commented Mar 14, 2021

ℹ Computer information

  • PowerToys version: 0.33.1
  • PowerToy Utility: powerlauncher
  • Running PowerToys as Admin: yes
  • Windows build number: 10.0.19043.867

📝 Provide detailed reproduction steps (if any)

  1. have PowerShell 7 installed using the msi package (mine is x64)
  2. have powertoys running (in my testing i didn't need to open/interact with powerlauncher to have it happen)
  3. try to uninstall PowerShell 7 from control panel or try to update it with a newer msi package

✔️ Expected result

should complete uninstaling/updating without problems

❌ Actual result

it says that powerlauncher process should be terminated before proceeding.

📷 Screenshots

image

@LuanVSO LuanVSO added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Mar 14, 2021
@enricogior enricogior added Resolution-External External issue, unrelated to PowerToys and removed Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Mar 14, 2021
@enricogior
Copy link
Contributor

@LuanVSO
it's a Windows installer bug, you can manually quit PowerToys and then select OK, or chose Do not close applications and then select OK.

@LuanVSO
Copy link
Author

LuanVSO commented Mar 14, 2021

i just reported this because @crutkas asked for it on twitter.

@enricogior
Copy link
Contributor

@LuanVSO
OK thanks, but we have been seeing these type of random warnings again and again.
You can try to uninstall and reinstall PowerShell and very likely you won't see the warning a second time.

@crutkas
Copy link
Member

crutkas commented Mar 30, 2021

@enricogior, this is a different style issue, typically it is a warning that our installer needs something closed, why would powershell need to close Launcher?

@enricogior
Copy link
Contributor

@crutkas

typically it is a warning that our installer needs something closed

I think is the same Windows installer bug, just with reverse applications.

Can reproduce it? I can't (I regularly update PowerShell using the MSI installer).

@LuanVSO
Copy link
Author

LuanVSO commented Mar 30, 2021

looks like power launch has loaded(is using??) this dll from powershell 7
image

@enricogior
Copy link
Contributor

@LuanVSO
we'll investigate it, but it doesn't make any sense.

@enricogior enricogior reopened this Mar 30, 2021
@enricogior enricogior added Product-PowerToys Run Improved app launch PT Run (Win+R) Window and removed Resolution-External External issue, unrelated to PowerToys labels Mar 30, 2021
@crutkas
Copy link
Member

crutkas commented Mar 31, 2021

@enricogior, i can actually verify that screen. I don't 'get' why, but i see what @LuanVSO see.

I quit PT, and it doesn't come up. I restart PT and do the search like he has and PT has the a hook on that.

@enricogior
Copy link
Contributor

@LuanVSO @crutkas
what happens if you try to delete Microsoft.DiaSymReader.Native.amd64.dll while Process Explorer shows that is in use by PowerLauncher.exe?

@LuanVSO
Copy link
Author

LuanVSO commented Apr 12, 2021

image

@crutkas crutkas added this to the Stability Release milestone Jun 7, 2021
@crutkas crutkas added this to To do in 0.45 Release via automation Jun 7, 2021
@sba923
Copy link

sba923 commented Oct 17, 2021

@LuanVSO it's a Windows installer bug, you can manually quit PowerToys and then select OK, or chose Do not close applications and then select OK.

Can you please elaborate on what the Windows Installer precisely is? Is this a known, documented issue?

@sba923
Copy link

sba923 commented Oct 17, 2021

These days also PowerToys Awake is included in the message:
E9d-fOvXIAENGfX

FWIW I've collected some information about the situation at the time of the message, as well as an installer log. See https://1drv.ms/u/s!AjBPRo9wXw9s9IpRI0QQXQvPCKSwWA

@dedavis6797
Copy link
Contributor

This is interesting. From the conversation it doesn't appear that the PowerShell update fails, just that PowerToys is getting in the way and needs to be closed first. From that standpoint, I wouldn't mark this as a high priority item. We should continue to investigate, but this probably doesn't need to be tracked on release project board yet.

@dedavis6797 dedavis6797 removed this from To do in 0.45 Release Nov 2, 2021
@eliannelavoie
Copy link

eliannelavoie commented Feb 24, 2022

I have the same problem at work!

If Microsoft.DiaSymReader.Native.amd64.dll is found in the User or System PATH variables, it will use that version. It's definitely not about just Powershell: in our case, it's from another .NET Core app with dll files in the same folder.

Otherwise, it uses C:\Program Files\dotnet\shared\Microsoft.NETCore.App\5.0.14\Microsoft.DiaSymReader.Native.amd64.dll, which is what I assume is the case for most users.

Shouldn't it just always use the second path?

@kevin-he-01
Copy link

Can confirm this issue using PowerToy's own File LockSmith utility:
image

@crutkas crutkas added Priority-1 Bug that is high priority Issue-Bug Something isn't working labels Nov 7, 2022
@jaimecbernardo jaimecbernardo added this to To do in 0.66 Release Nov 15, 2022
@jaimecbernardo jaimecbernardo added this to To do in 0.68 Release via automation Jan 24, 2023
@jaimecbernardo jaimecbernardo removed this from To do in 0.66 Release Jan 24, 2023
@jaimecbernardo jaimecbernardo added this to To do in 0.71 Release via automation May 15, 2023
@jaimecbernardo jaimecbernardo removed this from To do in 0.68 Release May 15, 2023
@donlaci
Copy link
Collaborator

donlaci commented Jun 9, 2023

Hi,
I have tried to reproduce the issue, but could not. Haven't find any locked file, could also update PowerShell.
Please verify if it is still an issue with the latest (70.1) PT release. Thanks!
/needinfo

@donlaci donlaci self-assigned this Jun 9, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 9, 2023
@sba923
Copy link

sba923 commented Jun 9, 2023

Haven't experienced the issue when I upgraded PowerShell from 7.3.3 to 7.3.4, probably on 2023-04-14.

What was the PowerToys version back then?

Do we know what has been changed on either or both sides that could explain that the problem's gone?

@crutkas
Copy link
Member

crutkas commented Jun 9, 2023

@LuanVSO does this still happen? /needinfo

@LuanVSO
Copy link
Author

LuanVSO commented Jun 9, 2023

did powershell remove the dll?
image
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 9, 2023
@jaimecbernardo
Copy link
Collaborator

Not sure about powershell removing the dll, but that name looks like "Diagnostics Symbol Reader"?
We've been unable to repro and it seems to no longer be relevant, so we're closing the issue.

0.71 Release automation moved this from To do to Done Jun 27, 2023
@jaimecbernardo jaimecbernardo added Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.
Projects
No open projects
Development

No branches or pull requests

9 participants