Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Run' does not work with win+space combo #13517

Closed
1 task done
kalokng opened this issue Sep 30, 2021 · 13 comments
Closed
1 task done

'Run' does not work with win+space combo #13517

kalokng opened this issue Sep 30, 2021 · 13 comments
Assignees
Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@kalokng
Copy link

kalokng commented Sep 30, 2021

Microsoft PowerToys version

0.47.0

Running as admin

  • Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

  1. Set the activation shortcut to Win+Space
  2. Try with win+space but not works, instead the input language is changed (the win10 default behavior)
  3. Set the activation shortcut to Alt+Space
  4. Try with Alt+space and the run dialog shows.
  5. Restarted both PowerToys and Windows, but Win+Space still not works.

✔️ Expected Behavior

Both shortcut should works, as they did in 0.45.0

❌ Actual Behavior

Win+Space does not work, only Alt+Space works.

Other Software

No response

@kalokng kalokng added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 30, 2021
@franky920920
Copy link
Contributor

I think Windows itself takeover the Win + space as shortcut key to change IME's input method.
This=>
image

I am not sure if we can take over this.

@jaimecbernardo
Copy link
Collaborator

We did make some changes in 0.47 for PowerToys Run to use a keyboard shortcut, in order to fix some focus issues. When registering the shortcut fails, PowerToys Run still falls back to using the low level keyboard hook as before.
In my Windows 10, I've been able to use "Win+Space" successfully. Might this be a Windows 11 specific issue?

@kalokng ,
Could you please send a bug report?

Right-click on the PowerToys icon in the tray menu and select Report Bug
image
Drag and drop report into a GitHub comment.

@jaimecbernardo jaimecbernardo added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 30, 2021
@kalokng
Copy link
Author

kalokng commented Sep 30, 2021

I am using Windows 10, 20H2, build 19042.1237
I was able to override the Win+Space shortcut in 0.45.0, and aware that was the IME related hotkey.
In the configuration window, it is able to capture the win+space hotkey, not sure why.

Here is the bug report:
PowerToysReport_2021-09-30-20-16-47.zip

@ghost ghost added Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 30, 2021
@jaimecbernardo
Copy link
Collaborator

From the logs, it seems that PowerToys Run did try to set the low-level keyboard hook:

Registering global shortcut failed. Will use low-level keyboard hook instead.

I think I know what might be happening. The low-level keyboard hook is now registered by PowerToys Run itself, which doesn't run elevated. Can you confirm that Win+Space works on non-elevated windows?

@jaimecbernardo jaimecbernardo added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Team-Response An issue author responded so the team needs to follow up labels Sep 30, 2021
@kalokng
Copy link
Author

kalokng commented Sep 30, 2021

Yes you are right, after running PowerToys in non-elevated mode, i can use Win+Space as shortcut key

@ghost ghost added Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 30, 2021
@jaimecbernardo
Copy link
Collaborator

Still, it'd be good to have it work on elevated windows when PowerToys runs elevated as well, like before.
We need to come up some logic to have the register shortcut in the PowerToys Run process and the fallback low level keyboard hook in the PowerToys process as before.

@jaimecbernardo jaimecbernardo self-assigned this Oct 1, 2021
@jaimecbernardo jaimecbernardo added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Oct 1, 2021
@jaimecbernardo jaimecbernardo added this to To do in 0.49 Release via automation Oct 1, 2021
@jaimecbernardo jaimecbernardo removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 1, 2021
@franky920920 franky920920 removed the Needs-Team-Response An issue author responded so the team needs to follow up label Oct 9, 2021
@crutkas crutkas removed this from To do in 0.49 Release Oct 12, 2021
@crutkas crutkas added this to To do in 0.47 Release via automation Oct 12, 2021
@crutkas crutkas added the Hot Fix Items we will product an out-of-band release for label Oct 12, 2021
@crutkas
Copy link
Member

crutkas commented Oct 12, 2021

Shipped with 0.47.1

@crutkas crutkas closed this as completed Oct 12, 2021
0.47 Release automation moved this from To do to Done Oct 12, 2021
@daletman
Copy link

Issue kind of still exists for me. I'm on v0.47.1 and Win+Space combo does not work when Visual Studio is in focus. Any idea why?

@franky920920
Copy link
Contributor

Issue kind of still exists for me. I'm on v0.47.1 and Win+Space combo does not work when Visual Studio is in focus. Any idea why?

cc: @crutkas

@jaimecbernardo
Copy link
Collaborator

@daletman , do you have the new setting to use the global keyboard hook turned on ?

@crutkas
Copy link
Member

crutkas commented Oct 21, 2021

Is VS run under admin and PT is not?

@daletman
Copy link

@daletman , do you have the new setting to use the global keyboard hook turned on ?

This did the trick, thanks.

@crutkas They were both run under admin.

@franky920920
Copy link
Contributor

Is VS run under admin and PT is not?

@kalokng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
Development

No branches or pull requests

5 participants