Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerRename] Highlight rows that will be changed #14724

Closed
niels9001 opened this issue Dec 1, 2021 · 11 comments
Closed

[PowerRename] Highlight rows that will be changed #14724

niels9001 opened this issue Dec 1, 2021 · 11 comments
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@niels9001
Copy link
Contributor

Description of the new feature / enhancement

Add some sort of indicator or color to indicate that the file or folder will be updated.

Scenario when this would be used?

Currently, it's a bit hard to see if a filename will be updated or not. (if the Renamed column is empty). Showing this visually would be nice and easier to distinguish (especially when having lots of files).

Supporting information

No response

@niels9001 niels9001 added Product-PowerRename Refers to the PowerRename PowerToy Area-User Interface things that regard UX for PowerToys labels Dec 1, 2021
@htcfreek
Copy link
Collaborator

htcfreek commented Dec 1, 2021

xref: #1853

@Jay-o-Way
Copy link
Collaborator

xref: #1853

...and those who are linked to that one

@niels9001
Copy link
Contributor Author

@htcfreek @Jay-o-Way This what I was thinking about:

PowerRename hightlight

Thoughts?

@stefansjfw
Copy link
Collaborator

I like it! Very nice!

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Dec 1, 2021

Thoughts?

@niels9001 Makes so much sense when you see it! 👍🏻

@htcfreek
Copy link
Collaborator

htcfreek commented Dec 1, 2021

Looks Good. But I would use an other color. Blue looks like selected. Maybee green.

@niels9001
Copy link
Contributor Author

Looks Good. But I would use an other color. Blue looks like selected. Maybee green.

It uses the AccentColorLight1 brush, which is common across Windows apps. That means it will adjust based on your accent color. E.g. dark mode and pink:

image

@htcfreek
Copy link
Collaborator

htcfreek commented Dec 1, 2021

Looks Good. But I would use an other color. Blue looks like selected. Maybee green.

It uses the AccentColorLight1 brush, which is common across Windows apps. That means it will adjust based on your accent color. E.g. dark mode and pink:

image

Okay 👍🏻. We should care about contrast. And that it's possible to distinguish the rows.

@Jay-o-Way
Copy link
Collaborator

This would fix #608 (from oct. '19) right?

@niels9001
Copy link
Contributor Author

This would fix #608 (from oct. '19) right?

Oh, nice find :)

@niels9001 niels9001 added the Status-In progress This issue or work-item is under development label Dec 1, 2021
@niels9001 niels9001 added this to To do in 0.53 Release via automation Dec 1, 2021
@crutkas crutkas moved this from To do to In progress in 0.53 Release Dec 1, 2021
@niels9001 niels9001 moved this from In progress to Done in 0.53 Release Dec 2, 2021
@niels9001 niels9001 added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Dec 2, 2021
@crutkas
Copy link
Member

crutkas commented Jan 6, 2022

This is fixed in 0.53, get it at https://aka.ms/installPowerToys

@crutkas crutkas closed this as completed Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Product-PowerRename Refers to the PowerRename PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
Development

No branches or pull requests

5 participants