Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT Run] Windows Settings search doesn't return 'Device Discovery' option. #14729

Closed
1 task done
dougwl opened this issue Dec 1, 2021 · 12 comments
Closed
1 task done
Assignees
Labels
Idea-Enhancement New feature or request on an existing product Priority-3 Bug that is low priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@dougwl
Copy link

dougwl commented Dec 1, 2021

Microsoft PowerToys version

0.5.1

Running as admin

  • Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

With the settings plugin being enabled, search for 'device discovery' in PowerToys Run.

✔️ Expected Behavior

When searching by 'Device Discovery' an option referent to 'ms-settings-connectabledevices:devicediscovery' should be displayed, since it's part of the ms-settings commands specification.

❌ Actual Behavior

At the moment, no results are displayed.

Maybe it is intended behavior because this option opens the control center instead of the settings panel, but since I couldn't find anything talking about it here, perhaps opening a report is the right way to go.

Other Software

No response

@dougwl dougwl added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Dec 1, 2021
@franky920920
Copy link
Contributor

When searching by 'Device Discovery' an option referent to 'ms-settings-connectabledevices:devicediscovery' should be displayed, since it's part of the ms-settings commands specification

This should be the setting plugin, For ms-settings-connectabledevices:devicediscovery, this will be handled by the URI plugin.

cc: @htcfreek

@franky920920 franky920920 added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface labels Dec 1, 2021
@htcfreek
Copy link
Collaborator

htcfreek commented Dec 1, 2021

which os version?

If it's a win11 setting, we haven't updated the plugin for Win11 now. (There is a general issue for Win11.)

You can open the link itself with uri plugin too.

@Jay-o-Way Jay-o-Way removed the Run-Plugin Things that relate with PowerToys Run's plugin interface label Dec 1, 2021
@htcfreek
Copy link
Collaborator

htcfreek commented Dec 1, 2021

@dougwl
The destination of this url isn't a setting in the settings app. That's why it's not listed official as settings url and not part of the settings plugin atm.

Can you plz share your source where you found the list with this uri? This would help us to implement it.

@franky920920
Copy link
Contributor

@dougwl
Copy link
Author

dougwl commented Dec 2, 2021

The necessary information can be found here (IANA registration template):

https://www.iana.org/assignments/uri-schemes/prov/ms-settings-connectabledevices

and all the other uri-schemes that follow this pattern (middle of the page, just search by 'ms-settings-'):

https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml

This URI scheme seems reminiscent to others used in the previous Windows Phone 8
(https://docs.microsoft.com/en-us/previous-versions/windows/apps/jj207065(v=vs.105))


I'm guessing it's registered like that because it access a different compartment from the main settings app (connect ux), although still being part of it.

@htcfreek
Copy link
Collaborator

htcfreek commented Dec 6, 2021

@crutkas , @jaimecbernardo
Do we like to show results on settings search that aren't any real setting like the "Monitor/Projector connection ux"?

I think it doesn't fit into the concept of the settings plugin and I asking me which application (property for subtitle) we should assign to this results? Or should we make things more complicated by having a custom subtitle on this results? (I think that will be a bad idea.)

If we like to have such results I can implement it. Then please assign me.

@crutkas
Copy link
Member

crutkas commented Dec 7, 2021

Is the ask to go here, correct?
image

@crutkas crutkas added Idea-Enhancement New feature or request on an existing product Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Dec 7, 2021
@dougwl
Copy link
Author

dougwl commented Dec 7, 2021

image
image

@crutkas This is the one, what you've mentioned is a Developer option that share the same name with the uri

'ms-settings-connectabledevices: devicediscovery'.

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 7, 2021
@crutkas
Copy link
Member

crutkas commented Dec 8, 2021

for me, ms-settings-connectabledevices:devicediscovery just does Win+K

I'm ok with this but it would be low priority

@crutkas crutkas added Priority-3 Bug that is low priority Help Wanted We encourage anyone to jump in on these and submit a PR. and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Dec 8, 2021
@htcfreek
Copy link
Collaborator

@Aaron-Junker
can you please assign me. thank you.

@Aaron-Junker Aaron-Junker removed the Help Wanted We encourage anyone to jump in on these and submit a PR. label Mar 20, 2022
@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Mar 20, 2022
@htcfreek
Copy link
Collaborator

Can someone please update tags and project. Thank you.

@crutkas crutkas added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Mar 22, 2022
@crutkas crutkas added this to To do in 0.57 Release via automation Mar 22, 2022
@jaimecbernardo jaimecbernardo moved this from To do to Done in 0.57 Release Mar 23, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Apr 2, 2022

This is fixed with 0.57.0. Please head over to https://aka.ms/installpowertoys

@htcfreek htcfreek closed this as completed Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Priority-3 Bug that is low priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
Development

No branches or pull requests

6 participants