Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ColorPicker] Hex input field: 3 digits value is interpreted incorrectly #14969

Closed
1 task
htcfreek opened this issue Dec 12, 2021 · 3 comments
Closed
1 task
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Product-Color Picker All things around the Color Picker utility Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Dec 12, 2021

Microsoft PowerToys version

0.51.1

Running as admin

  • Yes

Area(s) with issue?

ColorPicker

Steps to reproduce

Open adjust color dialoge in CP Editor ux. Then type a 3 chars hex color value into text box.

✔️ Expected Behavior

The hex code is converted in background to 6 digits and will be represented correctly: CF0 => CCFF00

See this note on w3c.org: https://www.w3.org/TR/css-color-3/#rgb-color

❌ Actual Behavior

The three values are interpreted as the last three values of a six value hex code.

image

Other Software

No response

technical implementation

@htcfreek htcfreek added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-Color Picker All things around the Color Picker utility labels Dec 12, 2021
@htcfreek htcfreek self-assigned this Dec 12, 2021
@htcfreek htcfreek added the Area-User Interface things that regard UX for PowerToys label Dec 12, 2021
@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Dec 12, 2021
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Dec 12, 2021
@htcfreek
Copy link
Collaborator Author

@niels9001
This bug we have exists in the official WinUI 3 control too. Do you think we should open an issue if we have the fix in our code ready?

@htcfreek
Copy link
Collaborator Author

@niels9001 , @crutkas
I have opened microsoft/microsoft-ui-xaml#6499 for the winui3 control.

@crutkas crutkas added this to To do in 0.53 Release via automation Dec 27, 2021
@crutkas crutkas moved this from To do to Done in 0.53 Release Dec 27, 2021
@crutkas crutkas added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Dec 27, 2021
@crutkas
Copy link
Member

crutkas commented Jan 6, 2022

The was fixed in in 0.53. Head over to https://aka.ms/installpowertoys to try it out

@crutkas crutkas closed this as completed Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Product-Color Picker All things around the Color Picker utility Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
Development

No branches or pull requests

2 participants