Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powertoys Run lags after typing a single character #15364

Closed
1 task done
gioleppe opened this issue Jan 8, 2022 · 28 comments
Closed
1 task done

Powertoys Run lags after typing a single character #15364

gioleppe opened this issue Jan 8, 2022 · 28 comments
Assignees
Labels
Area-Quality Stability, Performance, Etc. Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@gioleppe
Copy link

gioleppe commented Jan 8, 2022

Microsoft PowerToys version

0.53.1

Running as admin

  • Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

Press alt + space and start typing a word
PowerToysReport_2022-01-08-19-39-49.zip

✔️ Expected Behavior

The typing should be smooth, and the word should appear as I type it on the keyboard

❌ Actual Behavior

The first character appears instantly, subsequent ones lag by a few seconds. Results are not updated until the word is completely typed.

Software

OS info:
Edition Windows 11 Home
Version 21H2
Installed on ‎7/‎31/‎2021
OS build 22000.376
Serial number LR0EV2RA
Experience Windows Feature Experience Pack 1000.22000.376.0

HW Specs

Device name LAPTOP-NUO67H1O
Processor AMD Ryzen 7 4700U with Radeon Graphics 2.00 GHz
Installed RAM 16.0 GB (15.4 GB usable)

@gioleppe gioleppe added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 8, 2022
@gioleppe
Copy link
Author

gioleppe commented Jan 8, 2022

Update: the bug doesn't seem to occur when prepending "?", "??", "=", "//", "<", ":", "{", "%%" or ">" to the query string, while the "$", ".", "!", prefix symbols seem to be affected as well, at least on my setup.

@franky920920 franky920920 added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Jan 9, 2022
@KatyPurry
Copy link

I have exactly the same behavior.

Powertoys 0.53.1
Windows 11 / OS build 22000.376

@denesberta
Copy link

I have the same issue too.

Powertoys 0.53.1
Windows 10 / OS build 19043.1415
CPU: i7-8700K
RAM: 24 GB

@jaimecbernardo
Copy link
Collaborator

I've just tried to revert some changes, and it seems that this change introduced this delay:
#15033

@jaimecbernardo jaimecbernardo self-assigned this Jan 10, 2022
@jaimecbernardo jaimecbernardo added the Status-In progress This issue or work-item is under development label Jan 10, 2022
@jaimecbernardo jaimecbernardo added this to To do in 0.55 Release via automation Jan 10, 2022
@jaimecbernardo
Copy link
Collaborator

For testing fixing the issue of "Delay after first character is input", would you mind installing a (non-signed) debug build to test if it fixes it?
https://github.com/jaimecbernardo/PowerToys/releases/tag/0.0.1-test-fix-issue-15395-ptrun-slowness

First uninstall your current installation of PowerToys, then install this fix build and test it.
@gioleppe
@Zazou49
@Dini108

Thanks, in advance.

@gioleppe
Copy link
Author

Of course, I will do it as soon as I get home :)

@erictbar
Copy link

@jaimecbernardo

I tried your build. Does not lag after first run, but it crashes on other occasions:

  1. Pres ctrl+alt+space to launch PT Run
  2. Type "term"
  3. Press down arrow then up arrow to select Windows Terminal
  4. Press delete
  5. Press any arrow key

PS Run will exit

This was replicated about 10 times in a row, but appears to be working for now.

PowerToysReport_2022-01-10-10-40-53.zip

@jaimecbernardo
Copy link
Collaborator

Hi @erictbar

Thanks for testing it.

I'm not actually seeing the mentioned 10 crashes in the logs you just sent though.
Even PowerToys Run is started only 3 times in the logs for this build, so I'm not sure how it could've crashed 10 times.
I've also tried replicating it on this new test installer, but without success.
Wonder where it came from. So, you're unable to replicate it anymore?

@gioleppe
Copy link
Author

@jaimecbernardo the dev version you provided seems to work fine for me. I tried to replicate @erictbar 's bug but I couldn't, everything is fine on my side.

If you want I can provide logs

@crispinb
Copy link

@jaimecbernardo - your debug build from worked for me for this issue, and hasn't caused any other problems thus far.

(arrived here from #15395 (comment))

@jaimecbernardo
Copy link
Collaborator

Thanks @gioleppe @crispinb.
I'm guessing that's some good confirmation already.

@erictbar
Copy link

erictbar commented Jan 10, 2022

@jaimecbernardo

Correct. And perhaps it wasn't a full crash, but it froze then disappeared. The 3 times might have been when it was bad enough that I had to toggle it off. It has been working.

One thing I noticed is sometimes when I search, I get a warning that "not all files are indexed":

image


I recently switched Windows settings to Enhanced indexing, though settings shows that there is 0 pending indexed file.

Edit: Found a fix here #15161 but just leaving this here in case Windows indexing could be a part of the issue,

@erictbar
Copy link

Happened again. Two times in a row. I forgot what I typed then. But now it is occurring consistently when I type "fidel" or "Apple Ca", "Eric B" or "winc" Freezes until I toggle off PT Run.

image
PowerToysReport_2022-01-10-16-30-38.zip

The only thing that these words have in common is that they are files or folders on an external drive that is BitLocker encrypted.*

Restarting the PC seems to have fixed it. I did the following before restarting:

  1. Remove the drive containing the suspected words from USB, tried again, crashed, plug back in
  2. Switch back to Classic search, issue persists

*After the computer restarted, I typed in the results again and the results all contain folders or files in %USERPROFILE%\iCloudDrive. iCloud is running on the PC and I have had freezes with File Explorer while using it recently, so that might be the culprit.

@crutkas crutkas moved this from To do to In progress in 0.55 Release Jan 11, 2022
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jan 11, 2022
@crutkas
Copy link
Member

crutkas commented Jan 11, 2022

@jaimecbernardo is this the tracking issue with everything dup'ed into?

@franky920920 franky920920 marked this as a duplicate and then as not a duplicate of #10603 Jan 11, 2022
@franky920920
Copy link
Contributor

[Off topic] Oops! Pasted on the wrong tab....

@jaimecbernardo
Copy link
Collaborator

@jaimecbernardo is this the tracking issue with everything dup'ed into?

@crutkas , yes let's make it this one.

@jaimecbernardo jaimecbernardo added Hot Fix Items we will product an out-of-band release for Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jan 11, 2022
@franky920920
Copy link
Contributor

franky920920 commented Jan 11, 2022

@crutkas / @jaimecbernardo Are we releasing 0.53.2? If so, there should be a few more issues that could be resolved with it in if possible.

@jaimecbernardo
Copy link
Collaborator

@franky920920 , which ones?

@franky920920
Copy link
Contributor

franky920920 commented Jan 11, 2022

Like the duplicates of loading the web search plugin for PT run.

@franky920920
Copy link
Contributor

franky920920 commented Jan 11, 2022

@jaimecbernardo #15344, like we do hotfix #14701.


Also maybe #15305 with PR #15324 is pending review to being merged
#11511 is this is possible for @davidegiacometti since that's an in-progress p-1 item
#15420 for reverting #15033

@jaimecbernardo
Copy link
Collaborator

@franky920920 , #15344 seems to be caused by a third-party plugin having been manually installed by the user, with a name which conflicts with our newly released "Web Search" plugin. (Check #15396 (comment) )
Non-officially supported scenario + we have to choose a way to "change" telemetry if we want to fix it (duplicate plugin name). Hotfix sounds unlikely.

@franky920920
Copy link
Contributor

franky920920 commented Jan 11, 2022

@jaimecbernardo Got it, I do miss #15396 (comment) :)

Please note there is three more issue/PRs I did edit into the previous comment.

@jaimecbernardo
Copy link
Collaborator

jaimecbernardo commented Jan 11, 2022

Thanks @franky920920

#15420 is the one that fixes this issue :)
#15305 issue is just that it gets written in the logs, not a user facing issue. But no harm in getting it included, anyway. Will take a look ;)

#11511 is not a regression. It should be treated like an usual fix, I think.

@jaimecbernardo jaimecbernardo moved this from In progress to Done in 0.55 Release Jan 11, 2022
@jaimecbernardo
Copy link
Collaborator

@franky920920 , we'll try to include #15344 in the hotfix after all.

@firefox97
Copy link

For testing fixing the issue of "Delay after first character is input", would you mind installing a (non-signed) debug build to test if it fixes it? https://github.com/jaimecbernardo/PowerToys/releases/tag/0.0.1-test-fix-issue-15395-ptrun-slowness

First uninstall your current installation of PowerToys, then install this fix build and test it. @gioleppe @Zazou49 @Dini108

Thanks, in advance.

The patch works for me!! Without it it is not usable! Thanks!

@Jay-o-Way Jay-o-Way added the Area-Quality Stability, Performance, Etc. label Jan 12, 2022
@franky920920
Copy link
Contributor

@firefox97 This is shipped with 0.53.3 release. Please update to the latest version with this patched!

@crutkas This should be closed as shipped.

@Jay-o-Way
Copy link
Collaborator

Should the hotfix be under Project .53 or .55?

@crutkas
Copy link
Member

crutkas commented Jan 31, 2022

The was fixed in in 0.53.3 / 0.55. Head over to https://aka.ms/installpowertoys to try it out

@crutkas crutkas closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Quality Stability, Performance, Etc. Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
Development

No branches or pull requests

10 participants