Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Setup] Do not require UAC prompt #15517

Closed
yuyoyuppe opened this issue Jan 13, 2022 · 8 comments
Closed

[Setup] Do not require UAC prompt #15517

yuyoyuppe opened this issue Jan 13, 2022 · 8 comments
Assignees
Labels
Area-Quality Stability, Performance, Etc. Area-Setup/Install Refers to installation mechanism Idea-Enhancement New feature or request on an existing product Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@yuyoyuppe
Copy link
Collaborator

yuyoyuppe commented Jan 13, 2022

Description of the new feature / enhancement

This depends on 2 things:

  • [Setup] Support per-user installation #15516
  • The fact that dotnet runtime requires elevation on install. WiX Bootstrapper cannot determine whether it'll require elevation based on dotnet being present in the system and proceeds to always require it. Looks like that behavior isn't configurable, so unless we move to another installation technology like WiXSharp, we can consider being blocked by it.

Scenario when this would be used?

That happens during installation/upgrade.

Supporting information

No response

@yuyoyuppe yuyoyuppe added Idea-Enhancement New feature or request on an existing product Area-Setup/Install Refers to installation mechanism Area-Quality Stability, Performance, Etc. labels Jan 13, 2022
@yuyoyuppe yuyoyuppe self-assigned this Jan 13, 2022
@o-l-a-v
Copy link

o-l-a-v commented Jan 13, 2022

Possible workaround: Compile self contained binaries, like Paint.NET does.

Or fail installing in user context if not running as admin and .NET desktop runtime isn't installed? But make everything else installable in user context.

@yuyoyuppe
Copy link
Collaborator Author

yuyoyuppe commented Jan 13, 2022

Compile self contained binaries

Yes, that could be an option, though since we ship many binaries, it could bloat the installation size to be N times bigger. Another concern would be receiving security fixes.

@Jay-o-Way
Copy link
Collaborator

Is this still an issue with the latest version? /needinfo

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Status-No recent activity no activity in the past 5 days when follow up's are needed labels Jan 12, 2023
@ghost
Copy link

ghost commented Jan 17, 2023

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

@ghost ghost closed this as completed Jan 23, 2023
@rooby
Copy link

rooby commented Jan 23, 2023

Should this still be open?

@ghost ghost removed the Status-No recent activity no activity in the past 5 days when follow up's are needed label Jan 23, 2023
@o-l-a-v
Copy link

o-l-a-v commented Jan 23, 2023

The installer still prompts for admin, even if pointing it to a "no admin required" install location, like %LOCALAPPDATA%\PowerToys. So this one ain't solved yet.

From the v0.66.0 installer after setting install path to said location.

image

@Jay-o-Way Jay-o-Way reopened this Jan 23, 2023
@crutkas crutkas added this to To do in 0.66 Release via automation Jan 25, 2023
@crutkas crutkas added this to To do in 0.67 Release via automation Jan 25, 2023
@crutkas crutkas removed this from To do in 0.66 Release Jan 25, 2023
@ghost ghost added the Status-No recent activity no activity in the past 5 days when follow up's are needed label Jan 28, 2023
@ghost
Copy link

ghost commented Jan 28, 2023

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

@Jay-o-Way Jay-o-Way removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Status-No recent activity no activity in the past 5 days when follow up's are needed labels Jan 28, 2023
@jaimecbernardo jaimecbernardo added this to To do in 0.68 Release via automation Feb 9, 2023
@jaimecbernardo jaimecbernardo removed this from To do in 0.67 Release Feb 9, 2023
@jaimecbernardo jaimecbernardo added this to To do in 0.69 Release via automation Feb 9, 2023
@jaimecbernardo jaimecbernardo removed this from To do in 0.68 Release Feb 9, 2023
@stefansjfw stefansjfw added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Mar 31, 2023
@Aaron-Junker Aaron-Junker moved this from To do to Done in 0.69 Release Apr 5, 2023
@crutkas
Copy link
Member

crutkas commented May 8, 2023

Fixed in 0.69 which was released in the start of April 2023.

@crutkas crutkas closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Quality Stability, Performance, Etc. Area-Setup/Install Refers to installation mechanism Idea-Enhancement New feature or request on an existing product Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
Development

No branches or pull requests

6 participants