Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerToys Run does not allow switching to windows on different desktops any more #15887

Closed
1 task
rah-jain opened this issue Feb 1, 2022 · 14 comments
Closed
1 task
Assignees
Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Regression This was working in a previous release

Comments

@rah-jain
Copy link

rah-jain commented Feb 1, 2022

Microsoft PowerToys version

0.55.0

Running as admin

  • Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

Have windows on multiple Windows desktops, try to use PowerToys Run to switch to a window on a different desktop by typing "<" followed by some portion of the window's name.

✔️ Expected Behavior

The window is available as a choice

❌ Actual Behavior

The window is not available as a choice.

Other Software

Windows 10, version 21H1

@rah-jain rah-jain added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 1, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 1, 2022

@rah-jain
Thank you for reporting this.

@crutkas
Please assign me.

I think I know why this is happening. It's the change I made to fix the bug with preloaded uwp windows. 🤨

Do we need a hotfix for this?

@franky920920 franky920920 added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Feb 1, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 1, 2022

Note to me:
Step 1: Revert change.
Step 2: Test if window is assigned to a VD and cloaked state. => VD-GUID of preloaded uwp window is always a guid with only zeros.
Step 3: Optional setting to show only on current VD.

@htcfreek
Copy link
Collaborator

htcfreek commented Feb 1, 2022

@crutkas
Can we use undocumented com interface in our code?

@crutkas
Copy link
Member

crutkas commented Feb 1, 2022

Nope, we are only allowed to use public APIs. Most virtual desktop APIs are private. For us to swap, I believe that is a private api.

@htcfreek
Copy link
Collaborator

htcfreek commented Feb 1, 2022

Nope, we are only allowed to use public APIs. Most virtual desktop APIs are private. For us to swap, I believe that is a private api.

@crutkas
Okay. Then I will try to use the official documented way.

I did a short test. We can filter by VirtualDesktop GUID. The GUID is available via an official COM-Interface. It contains only zeros for hidden uwp app windows because they aren't assigned to a desktop. (https://docs.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ivirtualdesktopmanager-getwindowdesktopid)

@htcfreek

This comment has been minimized.

@htcfreek htcfreek added Severity-Regression This was working in a previous release Status-In progress This issue or work-item is under development labels Feb 1, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 1, 2022

Note: The PR above is only the hotfix to bring the feature back into WW. The final fix of this issue will be in a second PR.

@jaimecbernardo jaimecbernardo added Hot Fix Items we will product an out-of-band release for Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Feb 2, 2022
@htcfreek htcfreek removed the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 2, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 2, 2022

I have removed Fix-committed lable because the hotfix isn't the final fix for this bug. With the hotfix I only reverted a change I had implemented to fix #13637.

@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Feb 2, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 2, 2022

@rah-jain
With the hotfix release 0.55.1 the windows should be visible again.

@rah-jain
Copy link
Author

rah-jain commented Feb 3, 2022

Confirmed, expected behavior is occurring in 0.55.1

@rah-jain rah-jain closed this as completed Feb 3, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 3, 2022

@rah-jain
Can you please reopen the issue.

@crutkas crutkas reopened this Feb 3, 2022
@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Feb 5, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 5, 2022

@crutkas
I have a solution which is nearly ready.

I have written a VirtualDesktopHelper class and my plan is to make it available to all plugins as part of Wox.Plugin.Common. The code only uses public documented interfaces! I know that there are some nits left and some improvements are needed. (At the moment I am waiting until #15807 and #15741 are merged before continue work.)

@jaimecbernardo jaimecbernardo added Status-In progress This issue or work-item is under development and removed Status-In progress This issue or work-item is under development labels Feb 23, 2022
@htcfreek htcfreek added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Mar 7, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Mar 7, 2022

project: v0.57.0 for the final solution

@Aaron-Junker Aaron-Junker added this to To do in 0.57 Release via automation Mar 7, 2022
@Aaron-Junker Aaron-Junker moved this from To do to Done in 0.57 Release Mar 7, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Apr 2, 2022

This is fixed with 0.57.0. Please head over to https://aka.ms/installpowertoys

@htcfreek htcfreek closed this as completed Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Regression This was working in a previous release
Projects
No open projects
Development

No branches or pull requests

5 participants