Exception Processing Message 0xc0000005 - Unexpected Parameters after installing

[hossimo]

Microsoft PowerToys version

0.56.1

Running as admin

• Yes

Area(s) with issue?

Welcome / PowerToys Tour window

Steps to reproduce

• Installed 0.56.1 overtop of 0.55.2
• Closed the welcome window after the updated version runs the first time.
  

After dismissing the error Powertools was still running in the tray and seemed to be working.

✔️ Expected Behavior

No Exception

❌ Actual Behavior

Exception Processing Message 0xc0000005

Other Software

N/A

[jaimecbernardo]

/bugreport

[ghost]

Hi there!

We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here? You right click on our system tray icon and just go to report bug. Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!

[hossimo]

PowerToysReport_2022-03-01-10-46-05.zip

[jaimecbernardo]

While I can't replicate the messagebox and I don't see this in the bug report event viewer logs, I'm able to get a crash in the settings app.
Here's how I do it:
1 - Open the settings.
2 - Open the "Welcome to PowerToys" window.
3 - Close the "Welcome to PowerToys" window.
4 - Close the settings window.

It adds an error event to Event Viewer.

[hossimo]

That's the exact issue I had with the addition of steps 1 and 4.

I don't believe I had the settings window open during the install of the upgrade, but when that "Welcome to PowerToys" window popped up after the first run and soon as I closed it I had the same crash.

[jaimecbernardo]

Making some notes here.
What's happening is that in https://github.com/microsoft/microsoft-ui-xaml/blob/82feccfdd44a5834332b9bf866dc9334407a6f99/dev/Materials/Backdrop/BackdropMaterial.cpp#L64-L69
m_connectedBrushCount is still > 0 because it was not cleaned when closing the OOBE window and current window ends up being null, which is not checked against in MicaController::SetTarget, trying to access a null pointer.

[jaimecbernardo]

Tried to add an handler for these exceptions is not supported in .net core: https://docs.microsoft.com/en-us/dotnet/api/system.runtime.exceptionservices.handleprocesscorruptedstateexceptionsattribute?view=net-6.0#remarks
This means fixing this crash might need to wait for proper WinUI 3 support and upgrade to .net framework 6.

[jaimecbernardo]

This was fixed by the WinUI 3 port of Settings. I no longer replicate it locally.