Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PowerOCR] probably wrap the Clipboard access in a try block #20088

Closed
yuyoyuppe opened this issue Aug 25, 2022 · 2 comments
Closed

[PowerOCR] probably wrap the Clipboard access in a try block #20088

yuyoyuppe opened this issue Aug 25, 2022 · 2 comments
Assignees
@yuyoyuppe
Labels
Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)

Comments

@yuyoyuppe
Copy link
Collaborator

@yuyoyuppe We should probably wrap the Clipboard access in a try block

PowerToys/src/modules/PowerOCR/PowerOCR/OCROverlay.xaml.cs

Line 275 in eedea31

Clipboard.SetText(grabbedText);

and probably log an error if access to the clipboard fails.

Originally posted by @TheJoeFin in #19172 (comment)
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 25, 2022
@yuyoyuppe yuyoyuppe changed the title [PowerOCR probably wrap the Clipboard access in a try block [PowerOCR] probably wrap the Clipboard access in a try block Aug 25, 2022
@yuyoyuppe yuyoyuppe added Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT) and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Aug 25, 2022
@TheJoeFin
Copy link
Collaborator

I think this issue is closed

@yuyoyuppe
Copy link
Collaborator Author

yep, thnx

@yuyoyuppe yuyoyuppe added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 6, 2022
@yuyoyuppe yuyoyuppe self-assigned this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuyoyuppe yuyoyuppe

Labels
Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuyoyuppe @TheJoeFin