Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PT Run not picking up an internet shortcut in the same folder as other internet shortcuts #23850

Closed
Nerxxy opened this issue Feb 4, 2023 · 11 comments
Closed

PT Run not picking up an internet shortcut in the same folder as other internet shortcuts #23850

Nerxxy opened this issue Feb 4, 2023 · 11 comments
Assignees
@jaimecbernardo
Labels
Cost-Small Small work item - 0-8 hours of work Idea-Enhancement New feature or request on an existing product Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Results (Programs) Issue with program search in PowerToys Run
Projects
0.68 Release

Comments

@Nerxxy
Copy link

Nerxxy commented Feb 4, 2023

Microsoft PowerToys version

0.67.0

Installation method

PowerToys auto-update

Running as admin

Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

  1. Make a steam friends shortcut (steam://open/friends)

  2. Use power toys run to search for the shortcut

  3. It doesn't show
    image

  4. Other internet shortcuts do
    image

✔️ Expected Behavior

The shortcut to show when searching for it in PT Run

❌ Actual Behavior

The shortcut does not show when searching for it in PT Run

Other Software

N/A
@Nerxxy Nerxxy added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 4, 2023
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 4, 2023

Thank you for reporting this. We need more information to find the reason. /bugreport

@Nerxxy
Copy link
Author

Nerxxy commented Feb 4, 2023

PowerToysReport_2023-02-04-15-20-53.zip

@jaimecbernardo
Copy link
Collaborator

I suspect this is because we only allow shortcuts for some protocols. I'm guessing steam:// it's not one of those.

@jaimecbernardo jaimecbernardo added Run-Results (Programs) Issue with program search in PowerToys Run and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Feb 6, 2023
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 6, 2023

I suspect this is because we only allow shortcuts for some protocols. I'm guessing steam:// it's not one of those.

steam:// is filtered for special cases.

@jaimecbernardo jaimecbernardo added Idea-Enhancement New feature or request on an existing product Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 6, 2023
@jaimecbernardo
Copy link
Collaborator

image
I'm guessing we need to add this new special case there in Win32Program.cs

@jaimecbernardo
Copy link
Collaborator

This is just a couple of mins. I'll just do it and open a quick PR

@jaimecbernardo jaimecbernardo added the Cost-Small Small work item - 0-8 hours of work label Feb 6, 2023
@jaimecbernardo jaimecbernardo added this to To do in 0.68 Release via automation Feb 6, 2023
@jaimecbernardo jaimecbernardo moved this from To do to In progress in 0.68 Release Feb 6, 2023
@jaimecbernardo jaimecbernardo self-assigned this Feb 6, 2023
@jaimecbernardo jaimecbernardo mentioned this issue Feb 6, 2023
Merged
11 tasks
@jaimecbernardo jaimecbernardo added the Status-In progress This issue or work-item is under development label Feb 6, 2023
@crutkas crutkas removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 6, 2023
@Nerxxy
Copy link
Author

Nerxxy commented Feb 6, 2023 •
edited
Loading

I suspect this is because we only allow shortcuts for some protocols. I'm guessing steam:// it's not one of those.

If that was the issue then rocket league shouldnt show up either as its shortcut is steam://rungameid/252950, no?

@htcfreek
Copy link
Collaborator

htcfreek commented Feb 7, 2023

I suspect this is because we only allow shortcuts for some protocols. I'm guessing steam:// it's not one of those.

If that was the issue then rocket league shouldnt show up either as its shortcut is steam://rungameid/252950, no?

We filter to show only steam://rungameid* and steam://run*. That's the reason why it was shown. No we added the case steam://open* too.

@Nerxxy
Copy link
Author

Nerxxy commented Feb 7, 2023

We filter to show only steam://rungameid* and steam://run*. That's the reason why it was shown. No we added the case steam://open* too.

ahh ok that makes more sense, thanks for clarifying

@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Feb 9, 2023
@jaimecbernardo jaimecbernardo moved this from In progress to Done in 0.68 Release Feb 9, 2023
@Aaron-Junker
Copy link
Collaborator

This was implemented in release 0.68. Thank you for the bug report!

@iceofice
Copy link

iceofice commented Oct 5, 2023

Is there any way too add more protocols? I just downloaded obsidian and I would like to use internet shortcut for "obsdian::".

@Lexomir Lexomir mentioned this issue Feb 6, 2024
Open
@github-actions github-actions bot mentioned this issue Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaimecbernardo jaimecbernardo

Labels
Cost-Small Small work item - 0-8 hours of work Idea-Enhancement New feature or request on an existing product Issue-Bug Something isn't working Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Results (Programs) Issue with program search in PowerToys Run
Projects
No open projects
0.68 Release
Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@crutkas @jaimecbernardo @Nerxxy @Aaron-Junker @htcfreek @iceofice