Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Peek] Exit preview by ESC key #26137

Closed
ngtrian opened this issue May 23, 2023 · 10 comments
Closed

[Peek] Exit preview by ESC key #26137

ngtrian opened this issue May 23, 2023 · 10 comments
Assignees
@davidegiacometti
Labels
Hot Fix Items we will product an out-of-band release for Idea-Enhancement New feature or request on an existing product Product-Peek Refers to Peek Powertoys Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
0.71 Release

Comments

@ngtrian
Copy link

ngtrian commented May 23, 2023

Description of the new feature / enhancement

Support exit preview by ESC key

Scenario when this would be used?

Support exit preview by ESC key

Supporting information

No response
@ngtrian ngtrian added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label May 23, 2023
@htcfreek htcfreek added Idea-Enhancement New feature or request on an existing product Product-Peek Refers to Peek Powertoys labels May 23, 2023
This was referenced May 23, 2023
Closed
Open
@jaimecbernardo jaimecbernardo mentioned this issue May 24, 2023
Closed
@davidegiacometti
Copy link
Collaborator

I really want this!
I will create a PR!

@davidegiacometti davidegiacometti self-assigned this May 24, 2023
@davidegiacometti davidegiacometti added this to To do in 0.71 Release via automation May 24, 2023
@davidegiacometti davidegiacometti added Status-In progress This issue or work-item is under development and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels May 24, 2023
@davidegiacometti davidegiacometti mentioned this issue May 24, 2023
Merged
11 tasks
@htcfreek
Copy link
Collaborator

@jaimecbernardo
Is it possible to have this in the hotfix if we release one? It is a highly requested feature.

@jaimecbernardo
Copy link
Collaborator

@jaimecbernardo
Is it possible to have this in the hotfix if we release one? It is a highly requested feature.

Yes. I think there's a PR open I'll look into tomorrow

@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label May 25, 2023
@Jay-o-Way Jay-o-Way mentioned this issue May 25, 2023
Closed
@davidegiacometti davidegiacometti added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels May 25, 2023
@crutkas crutkas moved this from To do to Done in 0.71 Release May 26, 2023
This was referenced May 27, 2023
Closed
Closed
Closed
Closed
@LeoRH123
Copy link

is it already released? I remembered that esc key closes power toys, but now it doesn't do anything.

@davidegiacometti
Copy link
Collaborator

is it already released? I remembered that esc key closes power toys, but now it doesn't do anything.

If you are on version 0.70.1 the ESC key closes Peek.

@LeoRH123
Copy link

LeoRH123 commented Jun 22, 2023 •
edited

is it already released? I remembered that esc key closes power toys, but now it doesn't do anything.

If you are on version 0.70.1 the ESC key closes Peek.

sometimes it works and sometimes it doesn't, I tried running Power Toys as admin but the issue is still there.

@davidegiacometti
Copy link
Collaborator

@LeoRH123 do you have more info? Are you able to reproduce the issue or does it happen with specific file type?

@LeoRH123
Copy link

@LeoRH123 do you have more info? Are you able to reproduce the issue or does it happen with specific file type?

it happens with some PDF files.

@davidegiacometti
Copy link
Collaborator

I can reproduce this.
It's happening with the previews that are using the WebView2 control.
After clicking in the WebView2 (PDF file or Monaco source code) ESC and arrow keys are swallowed by the WebView2.
I have created #27017

@crutkas
Copy link
Member

crutkas commented Jul 14, 2023

Fixed in 0.71 release of PowerToys. aka.ms/installpowertoys

@crutkas crutkas closed this as completed Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidegiacometti davidegiacometti

Labels
Hot Fix Items we will product an out-of-band release for Idea-Enhancement New feature or request on an existing product Product-Peek Refers to Peek Powertoys Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
0.71 Release
Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@crutkas @ngtrian @davidegiacometti @jaimecbernardo @LeoRH123 @htcfreek