Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT Run] Fix margin when FlowDirection is RightToLeft #30251

Merged
merged 1 commit into from Dec 7, 2023
Merged

[PT Run] Fix margin when FlowDirection is RightToLeft #30251

merged 1 commit into from Dec 7, 2023

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Switch OS language to Hebrew
  • Make sure keyboard language is also Hebrew
  • Start typing something in PT Run
  • Observe that suggest text and type text are aligned

@stefansjfw stefansjfw added the Hot Fix Items we will product an out-of-band release for label Dec 7, 2023
gokcekantarci
gokcekantarci approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@gokcekantarci gokcekantarci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

niels9001
niels9001 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks!

@stefansjfw stefansjfw merged commit d0acc8e into main Dec 7, 2023
14 checks passed
@crutkas crutkas deleted the stefan/fix_right_to_left_margin branch January 7, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niels9001 niels9001 niels9001 approved these changes

@gokcekantarci gokcekantarci gokcekantarci approved these changes

@donlaci donlaci Awaiting requested review from donlaci

Assignees
No one assigned
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefansjfw @niels9001 @gokcekantarci