Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] Settings UI crashes on empty value for HEX box #6022

Closed
Jay-o-Way opened this issue Aug 18, 2020 · 3 comments · Fixed by #6840
Closed

[FancyZones] Settings UI crashes on empty value for HEX box #6022

Jay-o-Way opened this issue Aug 18, 2020 · 3 comments · Fixed by #6840
Assignees
@arjunbalgovind
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
0.23 release
Milestone
InVEST-2010

Comments

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Aug 18, 2020 •
edited
Loading

ℹ Computer information

  • PowerToys version: 0.20.1
  • PowerToy Utility: Fancy Zones
  • Running PowerToys as Admin: yes
  • Windows build number: 10.0.19041.388

📝 Provide detailed reproduction steps (if any)

  1. Open Settings: Fancy Zones
  2. Go to edit one of the zone colors
  3. In the color picker window, delete the #HEX value (ether manually or via the X button)

✔️ Expected result

What is the expected result of the above steps?
I think nothing? Similar to clearing one of the RGB boxes.

❌ Actual result

What is the actual result of the above steps?
UI freezes for one to five seconds and then closes.
PowerToys itself does not close all together.

📷 Screenshots

Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form
image
@Jay-o-Way Jay-o-Way added the Issue-Bug Something isn't working label Aug 18, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 18, 2020
@Jay-o-Way Jay-o-Way changed the title [FancyZones] UI crashes on empty value for HEX box [FancyZones] Settings UI crashes on empty value for HEX box Aug 18, 2020
@arjunbalgovind arjunbalgovind added the Product-Settings The standalone PowerToys Settings application label Aug 18, 2020
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 24, 2020
@crutkas crutkas added this to To do in 0.23 release via automation Aug 24, 2020
@crutkas crutkas added the Priority-0 Bugs that we consider release-blocking/recall-class (P0) label Aug 24, 2020
@crutkas crutkas added this to the InVEST-2009 milestone Aug 24, 2020
@arjunbalgovind arjunbalgovind self-assigned this Aug 31, 2020
@arjunbalgovind arjunbalgovind added the Status-In progress This issue or work-item is under development label Aug 31, 2020
This was referenced Aug 31, 2020
Closed
Closed
@arjunbalgovind
Copy link
Contributor

microsoft/microsoft-ui-xaml#3222 was created to track the bug in the WinUI repository. A workaround for the bug has been added in the PR #6258.

@arjunbalgovind arjunbalgovind moved this from To do to In progress in 0.23 release Aug 31, 2020
@arjunbalgovind
Copy link
Contributor

This should be fixed in the next pre-release of WinUI as per the comment on microsoft/microsoft-ui-xaml#3222. @ryanbodrug-microsoft keeping this issue open so that we update to the new version when it is out

@saahmedm saahmedm added External Dependency-WinUI 3 Dependency on WinUI Status-Blocked We can't make progress due to a dependency or issue labels Sep 22, 2020
@saahmedm saahmedm modified the milestones: InVEST-2009, InVEST-2010 Sep 22, 2020
@Jay-o-Way Jay-o-Way mentioned this issue Sep 24, 2020
Closed
@crutkas crutkas added this to To do in 0.25 release via automation Sep 24, 2020
@crutkas crutkas removed this from In progress in 0.23 release Sep 24, 2020
@crutkas crutkas moved this from To do to In progress in 0.25 release Sep 24, 2020
@arjunbalgovind arjunbalgovind mentioned this issue Sep 25, 2020
Merged
3 tasks
0.25 release automation moved this from In progress to Done Sep 25, 2020
@ghost ghost added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Sep 25, 2020
0.25 release automation moved this from Done to In progress Sep 25, 2020
@arjunbalgovind arjunbalgovind added this to To do in 0.23 release via automation Sep 25, 2020
@arjunbalgovind arjunbalgovind moved this from To do to Done in 0.23 release Sep 25, 2020
@arjunbalgovind arjunbalgovind removed this from In progress in 0.25 release Sep 25, 2020
@arjunbalgovind arjunbalgovind removed External Dependency-WinUI 3 Dependency on WinUI Status-Blocked We can't make progress due to a dependency or issue labels Sep 25, 2020
@crutkas
Copy link
Member

crutkas commented Sep 30, 2020

Fixed in 0.23 of PowerToys. https://github.com/microsoft/PowerToys/releases/

@crutkas crutkas closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjunbalgovind arjunbalgovind

Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
0.23 release
  
Done
Milestone
InVEST-2010
Development

Successfully merging a pull request may close this issue.

Updated winUI version in Settings.UI project arjunbalgovind/PowerToys
4 participants
@crutkas @arjunbalgovind @saahmedm @Jay-o-Way