Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FZ Editor] Launching the FZ editor through settings (when running) closes the instance, instead of switching to it #6868

Open
niels9001 opened this issue Sep 28, 2020 · 6 comments
Labels
Area-User Interface things that regard UX for PowerToys FancyZones-Editor Issue revolving the FancyZone Editor Product-FancyZones Refers to the FancyZones PowerToy Product-Settings The standalone PowerToys Settings application

Comments

@niels9001
Copy link
Contributor

niels9001 commented Sep 28, 2020

ℹ Computer information

  • PowerToys version: 0.22
  • PowerToy Utility: FZ

📝 Provide detailed reproduction steps (if any)

  1. Open PT settings and navigate to the FancyZones page.
  2. Click on "Launch zones editor"
  3. Switch back to PT settings.
  4. Click on the button again.

✔️ Expected result

Clicking on "Launch zone editor" should open the FZ editor or, when already running, switch to it.

❌ Actual result

The running instance of the FZ editor is closed and nothing happens. Requires you to click on the button agian.

📷 Screenshots

Editor bug2

@niels9001 niels9001 added the Issue-Bug Something isn't working label Sep 28, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 28, 2020
@enricogior
Copy link
Contributor

It's currently by design.

@niels9001
Copy link
Contributor Author

Any particular reason? Would be nice if it would kill the process and then restart it. As a user, I'm currently left wondering what is happening.

@enricogior
Copy link
Contributor

It's for consistency with the hotkey, pressing Win + ` once open the editor, pressing it again closes it.
The button in the Settings calls the exact same code.
We can reconsider it, but it doesn't seem like a high priority issue at the moment. It has been like that since the first release and the users seems to be fine with it.

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Oct 1, 2020

Haven't noticed this because I don't use FZ much and I wouldn't often come to these actions. I can totally understand Niels's point though.
If this is - and will stay - this way by design, then the text on the button is incorrect, because it both launches and closes the Editor. This makes the issue valid. In short: either launch it or toggle it (the decision is up to you) but the text must match the action.

@enricogior
Copy link
Contributor

@Jay-o-Way
on cars you have the start button, that is also the stop button, so I think most people are used to the concept that the same button starts and stops something. For sure it would be nice to trigger the button text to reflect the current state.

@enricogior enricogior added FancyZones-Editor Issue revolving the FancyZone Editor Product-Settings The standalone PowerToys Settings application Area-User Interface things that regard UX for PowerToys and removed Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Dec 29, 2020
@enricogior enricogior changed the title [FancyZones editor] Launching the FZ editor through settings (when running) kills the instance, instead of switching to it [FZ Editor] Launching the FZ editor through settings (when running) closes the instance, instead of switching to it Feb 6, 2021
@Jay-o-Way
Copy link
Collaborator

on cars you have the start button, that is also the stop button

That's just as good an argument as the famous "Go to Start to Shut down". Doesn't make it right.

@Aaron-Junker Aaron-Junker added the Product-FancyZones Refers to the FancyZones PowerToy label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys FancyZones-Editor Issue revolving the FancyZone Editor Product-FancyZones Refers to the FancyZones PowerToy Product-Settings The standalone PowerToys Settings application
Projects
None yet
Development

No branches or pull requests

4 participants