Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shortcut Guide] Xbox Game Bar has incorrect casing #6884

Closed
hamiltonia opened this issue Sep 28, 2020 · 11 comments
Closed

[Shortcut Guide] Xbox Game Bar has incorrect casing #6884

hamiltonia opened this issue Sep 28, 2020 · 11 comments
Labels
Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-Shortcut Guide Refers to the Shortcut Guide PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@hamiltonia
Copy link

hamiltonia commented Sep 28, 2020

ℹ Computer information

  • PowerToys version: v0.18.2
  • PowerToy Utility: Shortcut Guide
  • Running PowerToys as Admin: No
  • Windows build number: 19041.508

📝 Provide detailed reproduction steps (if any)

  1. Press and hold the Windows key
  2. Shortcut view shows

✔️ Expected result

G - "Open Game Bar" (capital B) should be shown

❌ Actual result

G - "Open Game bar" is in the list of shortcuts,

I know it's small, but we worked for that B (it's also incorrect in some places in Windows, we'll fix that soon).

@hamiltonia hamiltonia added the Issue-Bug Something isn't working label Sep 28, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 28, 2020
@phizch
Copy link

phizch commented Sep 29, 2020

I assume that you want the capital B. You've probably switched expected and actual results 😉. Otherwise it works as expected on my computer (lowercase b).

@niels9001
Copy link
Contributor

image

Good catch - It should indeed be a capital B.

@Aaron-Junker Aaron-Junker added Product-Shortcut Guide Refers to the Shortcut Guide PowerToy and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 29, 2020
@enricogior enricogior added the Help Wanted We encourage anyone to jump in on these and submit a PR. label Sep 29, 2020
@niels9001
Copy link
Contributor

@enricogior - happy to do it. I'll assign myself.

@niels9001 niels9001 self-assigned this Sep 29, 2020
@crutkas crutkas added this to To do in 0.25 release via automation Sep 29, 2020
@crutkas crutkas changed the title Xbox Game Bar spelled incorrectly Xbox Game Bar has incorrect casing Sep 29, 2020
@crutkas
Copy link
Member

crutkas commented Sep 29, 2020

Nit, it isn't spelled incorrectly, it has incorrect casing :)

@hamiltonia
Copy link
Author

My apologies for the buggy bug report - yes, the expected value is a capitalized B in Bar. Thanks!

@crutkas crutkas moved this from To do to In progress in 0.25 release Sep 30, 2020
@crutkas crutkas moved this from In progress to To do in 0.25 release Sep 30, 2020
@niels9001
Copy link
Contributor

@crutkas Seems that these .SVGs are generated in Sketch. I'm running into some issues editing these since everything is transformed to shapes, instead of text.

Is there a way to get the actual design file? Would be good to have that as a resource in the repo anyways?

@niels9001 niels9001 changed the title Xbox Game Bar has incorrect casing [Shortcut Guide] Xbox Game Bar has incorrect casing Oct 24, 2020
@ghost
Copy link

ghost commented Nov 19, 2020

Someone remove this from 0.25

@crutkas
Copy link
Member

crutkas commented Nov 20, 2020

@niels9001, what do we need here to push this forward? can we just recreate the SVG?

@crutkas crutkas added this to To do in 0.29 release via automation Nov 20, 2020
@crutkas crutkas removed this from To do in 0.25 release Nov 20, 2020
@niels9001
Copy link
Contributor

@crutkas When I updated the .svg I got an error when running the Shortcut Guide project. I think the code looks for specific IDs in the SVG? If we have the original file we can make the changes and do a new export.

@enricogior enricogior added the Priority-3 Bug that is low priority label Nov 20, 2020
@enricogior enricogior removed this from To do in 0.29 release Dec 28, 2020
@enricogior enricogior added this to To do in 0.33 Release via automation Dec 28, 2020
@enricogior enricogior added this to To do in 0.37 Release via automation Jan 29, 2021
@enricogior enricogior removed this from To do in 0.33 Release Jan 29, 2021
@niels9001 niels9001 removed their assignment Feb 27, 2021
@enricogior enricogior removed this from To do in 0.37 Release Mar 22, 2021
@enricogior enricogior added the Planning-Consideration Consideration for 2021 stability release label Mar 22, 2021
@niels9001 niels9001 added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 5, 2021
@niels9001 niels9001 added this to To do in 0.51 Release via automation Nov 5, 2021
@niels9001 niels9001 moved this from To do to Done in 0.51 Release Nov 5, 2021
@niels9001 niels9001 removed Help Wanted We encourage anyone to jump in on these and submit a PR. Planning-Consideration Consideration for 2021 stability release labels Nov 5, 2021
@crutkas
Copy link
Member

crutkas commented Nov 30, 2021

This is fixed in 0.51. Please head over to our releases and get the update! https://aka.ms/installpowertoys

@crutkas crutkas closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-Shortcut Guide Refers to the Shortcut Guide PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
Development

No branches or pull requests

6 participants