Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors when using TFM of 17763 #921

Closed
andrewleader opened this issue Jun 9, 2021 · 2 comments
Closed

Build errors when using TFM of 17763 #921

andrewleader opened this issue Jun 9, 2021 · 2 comments
Assignees
Labels
area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) bug Something isn't working
Milestone

Comments

@andrewleader
Copy link
Contributor

Describe the bug
This is a known issue (we need to update the NuGet package dependencies in the Microsoft.ProjectReunion.WinUI NuGet package). Despite Project Reunion supporting down to build 17763 of Windows 10, if you use the .NET TFM of net5.0-windows10.0.17763 or set the packaging project's <TargetPlatformVersion> to 17763 or lower, the project won't build, receiving build errors like Project XYZ is not compatible with uap10.0.17763.

Workaround
Update your TFM to net5.0-windows10.0.18362 or higher, and in your packaging project, update your <TargetPlatformVersion> to 18362 or higher. This will not prevent you from running on 17763 (MinVersion declares that). This only affects what APIs are available (more APIs will be available by targeting a higher version).

Steps to reproduce the behavior:

  1. Create a 0.5 or 0.8 Preview WinUI 3 desktop app
  2. Change the TFM to net5.0-windows10.0.17763, or change the packaging project's <TargetPlatformVersion> to 17763
  3. Try to build the project

Expected behavior
Building and deploying should succeed, since Project Reunion supports down to 17763.

Version Info

NuGet package version:
Version 0.5.7 and 0.8.0-preview

Root cause
The Microsoft.ProjectReunion.WinUI NuGet package declares a dependency on net5.0-windows10.0.18362 or higher, when this instead should be targeting net5.0-windows10.0.17763. Internal bug number 33525703.

@andrewleader andrewleader added bug Something isn't working area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) v0.5 labels Jun 9, 2021
@andrewleader andrewleader self-assigned this Jun 10, 2021
@asklar
Copy link
Member

asklar commented Jun 23, 2021

@andrewleader how should this work for libraries (as opposed to apps)? we have a winrt library written (in C++) that we are projecting onto C# / reunion via cswinrt, we would like to make the library available to the most number of apps, but when using 17763 we hit this issue.

@andrewleader
Copy link
Contributor Author

Fixed in upcoming 1.0 Preview 2. You'll now be able to use a TFM of 17763 in apps (or libraries) with WinAppSDK 1.0 Preview 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants