Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppLifecycle Activation.md #434

Merged
merged 17 commits into from Mar 12, 2021
Merged

Conversation

andreww-msft
Copy link
Contributor

Added the exePath parameter to Register/Unregister methods.

Added the exePath parameter to Register/Unregister methods.
@andreww-msft andreww-msft self-assigned this Feb 10, 2021
@ghost ghost added the needs-triage label Feb 10, 2021
Fixed the array declarations.
@riverar
Copy link
Contributor

riverar commented Feb 11, 2021

Missing documentation on what constitutes a valid image resource file when specifying a logo via RegisterForFileTypeActivation. It's my understanding the Shell only supports ICOs with BMP or PNG data within.

Changed RegisterForStartupActivation isEnabled to isDisabled.
@andrewleader andrewleader mentioned this pull request Feb 13, 2021
Updated Startup registration to remove displayName, and add taskId to unregister.
Fixed array declarations again.
Removed isEnabled from StartupTask registration, as it makes no sense.
Dropped all the function overloads, added DisplayName to File & Protocol, added Logo to Protocol.
Removed toast sample snippet.
Renamed to AppInstance, and updated ExtendedActivationKind.
Renamed AppLifecycle to AppInstance, updated instancing APIs.
Made GetActivatedEventArgs an instance method instead of static.
Made GetActivatedEventArgs an instance method not static.
Added ProcessId example.
@jonwis jonwis added the api-design Updates to Project Reunion API surfaces label Mar 6, 2021
@andreww-msft andreww-msft merged commit 1246c72 into user/andreww-msft Mar 12, 2021
@andreww-msft andreww-msft deleted the andreww-msft-patch-1 branch March 12, 2021 18:17
andreww-msft added a commit that referenced this pull request Mar 24, 2021
* Create .gitkeep

* Create .gitkeep

* Create .gitkeep

* Create .gitkeep

* Added AppLifecycle State/Power Notifications API spec. (#278)

* Add files via upload

Added AppLifecycle State/Power Notifications API spec.

* Update AppLifecycle StateNotifications.md

* Update AppLifecycle StateNotifications.md

* Added AppLifecycle Activation API spec. (#279)

* Add files via upload

* Update AppLifecycle Activation.md

* Update AppLifecycle Activation.md

* Update AppLifecycle Activation.md (#401)

* Update AppLifecycle Activation.md

* Added AppLifecycle Single/Multi-instancing API spec. (#280)

* Add files via upload

* Update AppLifecycle SingleMulti-Instancing.md

* Update AppLifecycle SingleMulti-Instancing.md

Removed toast sample snippet.

* Update AppLifecycle Activation.md (#434)

* Update AppLifecycle Activation.md

Added the exePath parameter to Register/Unregister methods.

* Update AppLifecycle Activation.md

Fixed the array declarations.

* Update AppLifecycle Activation.md

Changed RegisterForStartupActivation isEnabled to isDisabled.

* Update AppLifecycle Activation.md

Updated Startup registration to remove displayName, and add taskId to unregister.

* Update AppLifecycle Activation.md

Fixed array declarations again.

* Update AppLifecycle Activation.md

Removed isEnabled from StartupTask registration, as it makes no sense.

* Update AppLifecycle Activation.md

Fixed typo.

* Update AppLifecycle Activation.md

Dropped all the function overloads, added DisplayName to File & Protocol, added Logo to Protocol.

* Update AppLifecycle SingleMulti-Instancing.md

Removed toast sample snippet.

* Update AppLifecycle Activation.md

Renamed to AppInstance, and updated ExtendedActivationKind.

* Update AppLifecycle SingleMulti-Instancing.md

Renamed AppLifecycle to AppInstance, updated instancing APIs.

* Update AppLifecycle Activation.md

* Update AppLifecycle Activation.md

Made GetActivatedEventArgs an instance method instead of static.

* Update AppLifecycle SingleMulti-Instancing.md

Made GetActivatedEventArgs an instance method not static.

* Update AppLifecycle Activation.md

Added ProcessId.

* Update AppLifecycle SingleMulti-Instancing.md

Added ProcessId.

* Update AppLifecycle Activation.md

Added ProcessId example.

* Tidy up app activation

* Tidy up instancing

* Tidy up power state

* Update AppLifecycle Activation.md

Resolved a number of review comments.

* Update AppLifecycle SingleMulti-Instancing.md

Fixed most review comments.

* Update AppLifecycle SingleMulti-Instancing.md

Additional review fixes.

* Update AppLifecycle Activation.md

* Update AppLifecycle Activation.md

* Update AppLifecycle SingleMulti-Instancing.md

* Update AppLifecycle StateNotifications.md

Updated per review comments.

Co-authored-by: Jon Wiswall <jonwis@microsoft.com>
wjk pushed a commit to SunburstApps/ProjectReunion that referenced this pull request Apr 12, 2021
* Create .gitkeep

* Create .gitkeep

* Create .gitkeep

* Create .gitkeep

* Added AppLifecycle State/Power Notifications API spec. (microsoft#278)

* Add files via upload

Added AppLifecycle State/Power Notifications API spec.

* Update AppLifecycle StateNotifications.md

* Update AppLifecycle StateNotifications.md

* Added AppLifecycle Activation API spec. (microsoft#279)

* Add files via upload

* Update AppLifecycle Activation.md

* Update AppLifecycle Activation.md

* Update AppLifecycle Activation.md (microsoft#401)

* Update AppLifecycle Activation.md

* Added AppLifecycle Single/Multi-instancing API spec. (microsoft#280)

* Add files via upload

* Update AppLifecycle SingleMulti-Instancing.md

* Update AppLifecycle SingleMulti-Instancing.md

Removed toast sample snippet.

* Update AppLifecycle Activation.md (microsoft#434)

* Update AppLifecycle Activation.md

Added the exePath parameter to Register/Unregister methods.

* Update AppLifecycle Activation.md

Fixed the array declarations.

* Update AppLifecycle Activation.md

Changed RegisterForStartupActivation isEnabled to isDisabled.

* Update AppLifecycle Activation.md

Updated Startup registration to remove displayName, and add taskId to unregister.

* Update AppLifecycle Activation.md

Fixed array declarations again.

* Update AppLifecycle Activation.md

Removed isEnabled from StartupTask registration, as it makes no sense.

* Update AppLifecycle Activation.md

Fixed typo.

* Update AppLifecycle Activation.md

Dropped all the function overloads, added DisplayName to File & Protocol, added Logo to Protocol.

* Update AppLifecycle SingleMulti-Instancing.md

Removed toast sample snippet.

* Update AppLifecycle Activation.md

Renamed to AppInstance, and updated ExtendedActivationKind.

* Update AppLifecycle SingleMulti-Instancing.md

Renamed AppLifecycle to AppInstance, updated instancing APIs.

* Update AppLifecycle Activation.md

* Update AppLifecycle Activation.md

Made GetActivatedEventArgs an instance method instead of static.

* Update AppLifecycle SingleMulti-Instancing.md

Made GetActivatedEventArgs an instance method not static.

* Update AppLifecycle Activation.md

Added ProcessId.

* Update AppLifecycle SingleMulti-Instancing.md

Added ProcessId.

* Update AppLifecycle Activation.md

Added ProcessId example.

* Tidy up app activation

* Tidy up instancing

* Tidy up power state

* Update AppLifecycle Activation.md

Resolved a number of review comments.

* Update AppLifecycle SingleMulti-Instancing.md

Fixed most review comments.

* Update AppLifecycle SingleMulti-Instancing.md

Additional review fixes.

* Update AppLifecycle Activation.md

* Update AppLifecycle Activation.md

* Update AppLifecycle SingleMulti-Instancing.md

* Update AppLifecycle StateNotifications.md

Updated per review comments.

Co-authored-by: Jon Wiswall <jonwis@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-design Updates to Project Reunion API surfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants