Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with documents filtering using tags #481

Closed
PaulineJaquot opened this issue Jan 31, 2024 · 6 comments · Fixed by #675
Closed

Issues with documents filtering using tags #481

PaulineJaquot opened this issue Jan 31, 2024 · 6 comments · Fixed by #675
Labels
bug Something isn't working
Milestone

Comments

@PaulineJaquot
Copy link
Collaborator

Hi,

We uploaded some files with multiple tags as seen below (e.g., project name: Wegstunnels AWA, project code: MN004259, tender outcome: Gewonnen)
image

When using these tags on the app frontend before querying the model, we got diverse errors:

  • When selecting only one of the three tags, the completion always states that no data source is found (see below the completion, in Dutch sorry)

image
image

  • When selecting two or all three tags, we get instead an error:
    image
    image

We have looked into the code and are struggling to pinpoint the reason why it fails. Could we get some support on this?

The Git commit of the source code from this repo is: 27df390

Thank you!

@dayland dayland added the bug Something isn't working label Jan 31, 2024
@ryonsteele
Copy link
Contributor

Hello - Found the issue here.
I have a solution in Pull Request #484
The issue being each tag was being quoted separately which was overloading the AZ Search function.
I made a change to normalize the parameter.

@PaulineJaquot
Copy link
Collaborator Author

That's great thank you, we'll try it out!

@PaulineJaquot
Copy link
Collaborator Author

Hi, we've just deployed the latest version of vNext-Dev (commit 0909c4b). The "Invalid Expression" error when using multiple tag is indeed gone, thank you! However, with one or multiple tag(s), the issue that no document source is found remains. If we query the database without any tag selected, we get an answer with citations. However, when we ask the same question but this time with one/multiple tag(s) selected, we get the message that no data source could be found (see screenshot in Dutch in previous message).

Is it this working well for you or other users?

@dayland dayland added this to the 1.1 milestone Feb 5, 2024
@ryonsteele
Copy link
Contributor

I think I have a better understanding of that search API and have an idea that should make searching with multiple tags way more accurate. Will update here when I have more.

@ryonsteele
Copy link
Contributor

@PaulineJaquot The fix for this was not in the query this time but in the index itself.
The change exists in this PR #491
However, will require re-indexing of the source documents to correct the tags field.

@dayland
Copy link
Contributor

dayland commented Apr 29, 2024

Resolved with latest release v1.1

@dayland dayland closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants